Author: vlendec
Date: 2006-07-01 23:59:32 +0000 (Sat, 01 Jul 2006)
New Revision: 16755

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16755

Log:
Hunting warning has some benefits....

Solaris found this one that needs to go into 3.0.23, actually munlock the
password memory.

Volker

Modified:
   branches/SAMBA_3_0/source/nsswitch/winbindd_cred_cache.c
   trunk/source/nsswitch/winbindd_cred_cache.c


Changeset:
Modified: branches/SAMBA_3_0/source/nsswitch/winbindd_cred_cache.c
===================================================================
--- branches/SAMBA_3_0/source/nsswitch/winbindd_cred_cache.c    2006-07-01 
23:56:09 UTC (rev 16754)
+++ branches/SAMBA_3_0/source/nsswitch/winbindd_cred_cache.c    2006-07-01 
23:59:32 UTC (rev 16755)
@@ -80,8 +80,8 @@
 #ifdef DEBUG_PASSWORD
                                DEBUG(10,("unlocking memory: %p\n", 
entry->pass));
 #endif
-                               memset(&(entry->pass), 0, len);
-                               if ((munlock(&entry->pass, len)) == -1) {
+                               memset(entry->pass, 0, len);
+                               if ((munlock(entry->pass, len)) == -1) {
                                        DEBUG(0,("failed to munlock memory: %s 
(%d)\n", 
                                                strerror(errno), errno));
                                        return map_nt_error_from_unix(errno);

Modified: trunk/source/nsswitch/winbindd_cred_cache.c
===================================================================
--- trunk/source/nsswitch/winbindd_cred_cache.c 2006-07-01 23:56:09 UTC (rev 
16754)
+++ trunk/source/nsswitch/winbindd_cred_cache.c 2006-07-01 23:59:32 UTC (rev 
16755)
@@ -80,8 +80,8 @@
 #ifdef DEBUG_PASSWORD
                                DEBUG(10,("unlocking memory: %p\n", 
entry->pass));
 #endif
-                               memset(&(entry->pass), 0, len);
-                               if ((munlock(&entry->pass, len)) == -1) {
+                               memset(entry->pass, 0, len);
+                               if ((munlock(entry->pass, len)) == -1) {
                                        DEBUG(0,("failed to munlock memory: %s 
(%d)\n", 
                                                strerror(errno), errno));
                                        return map_nt_error_from_unix(errno);

Reply via email to