Author: vlendec
Date: 2006-07-23 08:18:31 +0000 (Sun, 23 Jul 2006)
New Revision: 17199

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=17199

Log:
Add comment to the RID/SID miracle
Modified:
   branches/SAMBA_3_0/source/rpc_server/srv_lsa_nt.c


Changeset:
Modified: branches/SAMBA_3_0/source/rpc_server/srv_lsa_nt.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_server/srv_lsa_nt.c   2006-07-23 03:33:28 UTC 
(rev 17198)
+++ branches/SAMBA_3_0/source/rpc_server/srv_lsa_nt.c   2006-07-23 08:18:31 UTC 
(rev 17199)
@@ -873,7 +873,12 @@
 
                if (name->type == SID_NAME_UNKNOWN) {
                        name->dom_idx = -1;
-                       /* unknown sids should return the string representation 
of the SID */
+                       /* Unknown sids should return the string
+                        * representation of the SID. Windows 2003 behaves
+                        * rather erratic here, in many cases it returns the
+                        * RID as 8 bytes hex, in others it returns the full
+                        * SID. We (Jerry/VL) could not figure out which the
+                        * hard cases are, so leave it with the SID.  */
                        name->name = talloc_asprintf(p->mem_ctx, "%s", 
                                                     
sid_string_static(sids[i]));
                        if (name->name == NULL) {

Reply via email to