Author: metze Date: 2006-07-25 07:48:23 +0000 (Tue, 25 Jul 2006) New Revision: 17226
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=17226 Log: add some comments about ldap binds and pending requests metze Modified: branches/SAMBA_4_0/source/ldap_server/ldap_bind.c Changeset: Modified: branches/SAMBA_4_0/source/ldap_server/ldap_bind.c =================================================================== --- branches/SAMBA_4_0/source/ldap_server/ldap_bind.c 2006-07-25 03:41:32 UTC (rev 17225) +++ branches/SAMBA_4_0/source/ldap_server/ldap_bind.c 2006-07-25 07:48:23 UTC (rev 17226) @@ -125,6 +125,12 @@ conn = call->conn; + /* + * TODO: a SASL bind with a different mechanism + * should cancel an inprogress SASL bind. + * (see RFC 4513) + */ + if (!conn->gensec) { conn->session_info = NULL; @@ -268,6 +274,14 @@ struct ldapsrv_reply *reply; struct ldap_BindResponse *resp; + /* + * TODO: we should fail the bind request + * if there're any pending requests. + * + * also a simple bind should cancel an + * inprogress SASL bind. + * (see RFC 4513) + */ switch (req->mechanism) { case LDAP_AUTH_MECH_SIMPLE: return ldapsrv_BindSimple(call);
