> Add some const. What's the policy here? Should I do this in Samba4 as well?
yes please :-) There is at least one const violation in ldb right now (near operational.c line 247) that will be tricky to fix properly. It shouldn't affect Samba3 yet as Samba3 doesn't enable that module, but if you are compiling ldb standalone then you'll hit that one. We need to think more carefully about the right solution to that one. I think all the others are just janitor tasks. I'm hoping that Samba4 and Samba3 ldb will not diverge, unless its because we screw up the Samba4 one and you don't want to merge broken code. Hopefully with ldb in the build farm we'll know when its safe to merge. Cheers, Tridge
