Author: metze
Date: 2007-02-28 17:23:35 +0000 (Wed, 28 Feb 2007)
New Revision: 21592

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=21592

Log:
compress_name() returns NULL for names longer than 15 chars

giving NO_MEMORY back is ugly, so give a useful error

metze
Modified:
   branches/SAMBA_4_0/source/libcli/nbt/nbtname.c


Changeset:
Modified: branches/SAMBA_4_0/source/libcli/nbt/nbtname.c
===================================================================
--- branches/SAMBA_4_0/source/libcli/nbt/nbtname.c      2007-02-28 17:19:35 UTC 
(rev 21591)
+++ branches/SAMBA_4_0/source/libcli/nbt/nbtname.c      2007-02-28 17:23:35 UTC 
(rev 21592)
@@ -332,6 +332,12 @@
                return NT_STATUS_OK;
        }
 
+       if (strlen(r->name) > 15) {
+               return ndr_push_error(ndr, NDR_ERR_STRING,
+                                     "nbt_name longer as 15 chars: %s",
+                                     r->name);
+       }
+
        cname = compress_name(ndr, (const uint8_t *)r->name, r->type);
        NT_STATUS_HAVE_NO_MEMORY(cname);
 

Reply via email to