Author: jra Date: 2007-06-04 23:31:34 +0000 (Mon, 04 Jun 2007) New Revision: 23347
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23347 Log: Fix Coverity 363. Dead code elimination. Jeremy. Modified: branches/SAMBA_3_0/source/libsmb/clifile.c branches/SAMBA_3_0_25/source/libsmb/clifile.c branches/SAMBA_3_0_26/source/libsmb/clifile.c Changeset: Modified: branches/SAMBA_3_0/source/libsmb/clifile.c =================================================================== --- branches/SAMBA_3_0/source/libsmb/clifile.c 2007-06-04 22:29:23 UTC (rev 23346) +++ branches/SAMBA_3_0/source/libsmb/clifile.c 2007-06-04 23:31:34 UTC (rev 23347) @@ -1692,13 +1692,9 @@ goto out; } - if (num_eas) { - ea_list = TALLOC_ARRAY(ctx, struct ea_struct, num_eas); - if (!ea_list) { - goto out; - } - } else { - ea_list = NULL; + ea_list = TALLOC_ARRAY(ctx, struct ea_struct, num_eas); + if (!ea_list) { + goto out; } ea_size = (size_t)IVAL(rdata,0); Modified: branches/SAMBA_3_0_25/source/libsmb/clifile.c =================================================================== --- branches/SAMBA_3_0_25/source/libsmb/clifile.c 2007-06-04 22:29:23 UTC (rev 23346) +++ branches/SAMBA_3_0_25/source/libsmb/clifile.c 2007-06-04 23:31:34 UTC (rev 23347) @@ -1692,13 +1692,9 @@ goto out; } - if (num_eas) { - ea_list = TALLOC_ARRAY(ctx, struct ea_struct, num_eas); - if (!ea_list) { - goto out; - } - } else { - ea_list = NULL; + ea_list = TALLOC_ARRAY(ctx, struct ea_struct, num_eas); + if (!ea_list) { + goto out; } ea_size = (size_t)IVAL(rdata,0); Modified: branches/SAMBA_3_0_26/source/libsmb/clifile.c =================================================================== --- branches/SAMBA_3_0_26/source/libsmb/clifile.c 2007-06-04 22:29:23 UTC (rev 23346) +++ branches/SAMBA_3_0_26/source/libsmb/clifile.c 2007-06-04 23:31:34 UTC (rev 23347) @@ -1692,13 +1692,9 @@ goto out; } - if (num_eas) { - ea_list = TALLOC_ARRAY(ctx, struct ea_struct, num_eas); - if (!ea_list) { - goto out; - } - } else { - ea_list = NULL; + ea_list = TALLOC_ARRAY(ctx, struct ea_struct, num_eas); + if (!ea_list) { + goto out; } ea_size = (size_t)IVAL(rdata,0);
