Author: jra Date: 2007-07-17 02:17:23 +0000 (Tue, 17 Jul 2007) New Revision: 23910
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23910 Log: We used to deny renames on the source open for non-delete open. Turns out this is not the case. VL please test but this matches Windows behaviour. (I'll add a torture test tomorrow). Jeremy. Modified: branches/SAMBA_3_2/source/smbd/reply.c branches/SAMBA_3_2_0/source/smbd/reply.c Changeset: Modified: branches/SAMBA_3_2/source/smbd/reply.c =================================================================== --- branches/SAMBA_3_2/source/smbd/reply.c 2007-07-17 02:06:38 UTC (rev 23909) +++ branches/SAMBA_3_2/source/smbd/reply.c 2007-07-17 02:17:23 UTC (rev 23910) @@ -1863,6 +1863,12 @@ return NT_STATUS_NO_SUCH_FILE; } +#if 0 + /* We used to deny renames on the + * source open for non-delete open. + * Turns out this is not the case. + * VL please test but this matches + * Windows behaviour. JRA. */ if (S_ISDIR(pst->st_mode)) { return NT_STATUS_OK; } @@ -1872,6 +1878,9 @@ } return NT_STATUS_ACCESS_DENIED; +#else + return NT_STATUS_OK; +#endif } /******************************************************************* Modified: branches/SAMBA_3_2_0/source/smbd/reply.c =================================================================== --- branches/SAMBA_3_2_0/source/smbd/reply.c 2007-07-17 02:06:38 UTC (rev 23909) +++ branches/SAMBA_3_2_0/source/smbd/reply.c 2007-07-17 02:17:23 UTC (rev 23910) @@ -1862,6 +1862,12 @@ return NT_STATUS_NO_SUCH_FILE; } +#if 0 + /* We used to deny renames on the + * source open for non-delete open. + * Turns out this is not the case. + * VL please test but this matches + * Windows behaviour. JRA. */ if (S_ISDIR(pst->st_mode)) { return NT_STATUS_OK; } @@ -1871,6 +1877,9 @@ } return NT_STATUS_ACCESS_DENIED; +#else + return NT_STATUS_OK; +#endif } /*******************************************************************
