[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-191-gb5e37af

[Jeremy Allison]

The branch, v3-2-test has been updated
       via  b5e37af251a26648b0e4f59ca548c5374399175e (commit)
      from  5ab76b58c00dde89b56060482f5cdc5d0c6c56cb (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit b5e37af251a26648b0e4f59ca548c5374399175e
Author: Jeremy Allison <[EMAIL PROTECTED]>
Date:   Sun Nov 4 22:20:04 2007 -0800

    Don't alloc struct iface_struct nics[MAX_INTERFACES]; (128 entries)
    on the stack - use talloc.
    Jeremy

-----------------------------------------------------------------------

Summary of changes:
 source/lib/util_sock.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/lib/util_sock.c b/source/lib/util_sock.c
index d87d954..0209723 100644
--- a/source/lib/util_sock.c
+++ b/source/lib/util_sock.c
@@ -2082,7 +2082,7 @@ bool is_myname_or_ipaddr(const char *s)
        /* Maybe its an IP address? */
        if (is_ipaddress(servername)) {
                struct sockaddr_storage ss;
-               struct iface_struct nics[MAX_INTERFACES];
+               struct iface_struct *nics;
                int i, n;
 
                if (!interpret_string_addr(&ss, servername, AI_NUMERICHOST)) {
@@ -2093,12 +2093,19 @@ bool is_myname_or_ipaddr(const char *s)
                        return false;
                }
 
+               nics = TALLOC_ARRAY(talloc_tos(), struct iface_struct,
+                                       MAX_INTERFACES);
+               if (!nics) {
+                       return false;
+               }
                n = get_interfaces(nics, MAX_INTERFACES);
                for (i=0; i<n; i++) {
                        if (addr_equal(&nics[i].ip, &ss)) {
+                               TALLOC_FREE(nics);
                                return true;
                        }
                }
+               TALLOC_FREE(nics);
        }
 
        /* No match */


-- 
Samba Shared Repository