On Wed, Jan 16, 2008 at 09:54:00AM -0600, Alexander Bokovoy wrote: > > Offline files support and remote storage are for allowing communication > with > backup and archiving tools that mark files moved to a tape library as > offline. > We translate this info into corresponding CIFS offline file attribute and > mark an exported volume as remote storage. > > Async I/O force is to allow selective redirection of I/O operations to > asynchronous > processing in case it is viable at VFS module discretion. It is needed for > proper handling of offline files as performing regular I/O on offline > file will > block smbd.
This is bad code and needs fixing. Some problems : New vfs function, bool (*aio_force)(struct vfs_handle_struct *handle, struct files_struct *fsp); defined in the code as : int vfswrap_aio_force(struct vfs_handle_struct *handle, struct files_struct *fsp) THESE FUNCTION SIGNATURES DO NOT MATCH ! Also, int vfswrap_is_offline(struct vfs_handle_struct *handle, struct connection_struct *conn, const char *path, SMB_STRUCT_STAT *sbuf, bool *offline) Looks like a question for which the correct return is a bool. But it returns a tristate, 1, 0, -1. WHAT DO THESE THINGS MEAN ? This is just after 120 minutes looking at the code..... This design should have been discussed on samba-technical, not just dumped into the repository. Jeremy.
