The branch, v4-0-test has been updated
via ba495f9d19e7c7cfc9135a5d40e1050dd8f9ebc6 (commit)
from 5370484d25b8c7a5bde730d9be36ecbbb0aaf315 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v4-0-test
- Log -----------------------------------------------------------------
commit ba495f9d19e7c7cfc9135a5d40e1050dd8f9ebc6
Author: Stefan Metzmacher <[EMAIL PROTECTED]>
Date: Fri Jan 25 08:08:33 2008 +0100
repl_meta_data: add some TODOs to replmd_modify_originating()
metze
-----------------------------------------------------------------------
Summary of changes:
source/dsdb/samdb/ldb_modules/repl_meta_data.c | 17 +++++++++++++++++
1 files changed, 17 insertions(+), 0 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/dsdb/samdb/ldb_modules/repl_meta_data.c
b/source/dsdb/samdb/ldb_modules/repl_meta_data.c
index 5100b7c..441dbc9 100644
--- a/source/dsdb/samdb/ldb_modules/repl_meta_data.c
+++ b/source/dsdb/samdb/ldb_modules/repl_meta_data.c
@@ -509,6 +509,18 @@ static int replmd_modify_originating(struct ldb_module
*module,
return LDB_ERR_OPERATIONS_ERROR;
}
+ /* TODO:
+ * - get the whole old object
+ * - if the old object doesn't exist report an error
+ * - give an error when a readonly attribute should
+ * be modified
+ * - merge the changed into the old object
+ * if the caller set values to the same value
+ * ignore the attribute, return success when no
+ * attribute was changed
+ * - calculate the new replPropertyMetaData attribute
+ */
+
if (add_time_element(msg, "whenChanged", t) != 0) {
talloc_free(down_req);
return LDB_ERR_OPERATIONS_ERROR;
@@ -523,6 +535,11 @@ static int replmd_modify_originating(struct ldb_module
*module,
}
}
+ /* TODO:
+ * - sort the attributes by attid with replmd_ldb_message_sort()
+ * - replace the old object with the newly constructed one
+ */
+
ldb_set_timeout_from_prev_req(module->ldb, req, down_req);
/* go on with the call chain */
--
Samba Shared Repository
