The branch, v3-devel has been updated
via 67c0835226e189deba5856710a1dea19ac5f30fd (commit)
from 6579005e6490f1a99b3860627ba51decaeb864bd (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-devel
- Log -----------------------------------------------------------------
commit 67c0835226e189deba5856710a1dea19ac5f30fd
Author: Volker Lendecke <[EMAIL PROTECTED]>
Date: Sun Aug 31 12:15:35 2008 +0200
Fix Coverity ID 589, dead code
-----------------------------------------------------------------------
Summary of changes:
source/nsswitch/libwbclient/wbc_sid.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/nsswitch/libwbclient/wbc_sid.c
b/source/nsswitch/libwbclient/wbc_sid.c
index 324a19b..f4ffa4e 100644
--- a/source/nsswitch/libwbclient/wbc_sid.c
+++ b/source/nsswitch/libwbclient/wbc_sid.c
@@ -294,9 +294,18 @@ wbcErr wbcLookupSid(const struct wbcDomainSid *sid,
}
}
else {
+#if 0
+ /*
+ * Found by Coverity: In this particular routine we can't end
+ * up here with a non-NULL name. Further up there are just two
+ * exit paths that lead here, neither of which leave an
+ * allocated name. If you add more paths up there, re-activate
+ * this.
+ */
if (name != NULL) {
talloc_free(name);
}
+#endif
if (domain != NULL) {
talloc_free(domain);
}
--
Samba Shared Repository
