Can you add a comment about the discussions we had, so that next time someone look at this code and at the manpage we do not have to discuss this again ?
Simo. On Fri, 2008-09-05 at 17:33 -0500, Jeremy Allison wrote: > The branch, v3-devel has been updated > via 0bae1ef3de8fda5e1e2d641b14a408e627396912 (commit) > from 2d95ea38a2f1ead37121fcc036c21a7f20ff41f9 (commit) > > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-devel > > > - Log ----------------------------------------------------------------- > commit 0bae1ef3de8fda5e1e2d641b14a408e627396912 > Author: Jeremy Allison <[EMAIL PROTECTED]> > Date: Fri Sep 5 15:32:22 2008 -0700 > > Remove unecessary msync. > Jeremy. > > ----------------------------------------------------------------------- > > Summary of changes: > source/lib/tdb/common/io.c | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > > > Changeset truncated at 500 lines: > > diff --git a/source/lib/tdb/common/io.c b/source/lib/tdb/common/io.c > index 4ec18de..661f761 100644 > --- a/source/lib/tdb/common/io.c > +++ b/source/lib/tdb/common/io.c > @@ -191,10 +191,6 @@ int tdb_munmap(struct tdb_context *tdb) > if (tdb->map_ptr) { > int ret; > > - ret = msync(tdb->map_ptr, tdb->map_size, MS_SYNC); > - if (ret != 0) > - return ret; > - > ret = munmap(tdb->map_ptr, tdb->map_size); > if (ret != 0) > return ret; > > -- Simo Sorce Samba Team GPL Compliance Officer <[EMAIL PROTECTED]> Senior Software Engineer at Red Hat Inc. <[EMAIL PROTECTED]>
