On Mon, Dec 29, 2008 at 04:05:59PM -0600, Volker Lendecke wrote: > The branch, v3-2-test has been updated > via f03e6b8faf8f3222e3dcdaae906f48e2aa3eeba8 (commit) > via 228d0c9459e9187d671875eda03aaa1435ab8401 (commit) > from c0fc381ac7ad09fd454fd6802149c46b607069ee (commit) > > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test > > > - Log ----------------------------------------------------------------- > commit f03e6b8faf8f3222e3dcdaae906f48e2aa3eeba8 > Author: Volker Lendecke <[email protected]> > Date: Mon Dec 29 22:06:08 2008 +0100 > > Second part of the bugfix for #5933 > > Incrementing the next vuid did not correctly overflow > > Now we survive BENCH-SESSSETUP with -o 100000. Takes a while though :-) > > Thanks a lot to Ofer Tal <[email protected]> for reporting #5933 > > commit 228d0c9459e9187d671875eda03aaa1435ab8401 > Author: Volker Lendecke <[email protected]> > Date: Mon Dec 29 22:01:57 2008 +0100 > > First part of bugfix for #5933 > > Ofer Tal <[email protected]> fully correctly noted that we're incrementing > num_validated_vuids twice per session setup, but decrement it only once. > Looking at sesssetup.c we always call register_initial_vuid() before > register_existing_vuid(), so there's no point in incrementing it in > register_existing_vuid(). > > Jeremy, please check!
At first evaluation this looks like a long-needed tidyup and bugfix - thanks ! I'll look at the torture test next which should confirm it :-). Thanks, Jeremy.
