The branch, v3-3-test has been updated
via 8241669521772cc75a9ca278a7f9a57256907ded (commit)
from 8e11901f92b2ecb976f0c24c5eb96fb6b8127207 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test
- Log -----------------------------------------------------------------
commit 8241669521772cc75a9ca278a7f9a57256907ded
Author: Jeremy Allison <[email protected]>
Date: Thu Jan 29 17:30:45 2009 -0800
Fix coverity CID#116. Resource leak on error path.
Jeremy.
-----------------------------------------------------------------------
Summary of changes:
source/libnet/libnet_samsync_ldif.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/libnet/libnet_samsync_ldif.c
b/source/libnet/libnet_samsync_ldif.c
index 4286331..cee0e17 100644
--- a/source/libnet/libnet_samsync_ldif.c
+++ b/source/libnet/libnet_samsync_ldif.c
@@ -542,8 +542,10 @@ static NTSTATUS fetch_group_info_to_ldif(TALLOC_CTX
*mem_ctx,
groupmap->sambaSID = talloc_asprintf(mem_ctx, "%s-%d", sid, g_rid);
groupmap->group_dn = talloc_asprintf(mem_ctx,
"cn=%s,ou=%s,%s", groupname, group_attr, suffix);
- NT_STATUS_HAVE_NO_MEMORY(groupmap->sambaSID);
- NT_STATUS_HAVE_NO_MEMORY(groupmap->group_dn);
+ if (groupmap->sambaSID == NULL || groupmap->group_dn == NULL) {
+ SAFE_FREE(group_attr);
+ return NT_STATUS_NO_MEMORY;
+ }
/* Write the data to the temporary add ldif file */
fprintf(add_fd, "# %s, %s, %s\n", groupname, group_attr,
--
Samba Shared Repository
