The branch, master has been updated
       via  309924e5c1da5ee6bf14f48e9f7d10d4348b8f77 (commit)
      from  946beae010145cc5066f81eb5e4b5e6392a37e2e (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 309924e5c1da5ee6bf14f48e9f7d10d4348b8f77
Author: Kai Blin <[email protected]>
Date:   Thu Jun 25 19:38:51 2009 +0200

    s4 auth_winbind: Don't allocate the rids for the info3 structure within the 
loop

-----------------------------------------------------------------------

Summary of changes:
 source4/auth/ntlm/auth_winbind.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/auth/ntlm/auth_winbind.c b/source4/auth/ntlm/auth_winbind.c
index a41c37e..3905d00 100644
--- a/source4/auth/ntlm/auth_winbind.c
+++ b/source4/auth/ntlm/auth_winbind.c
@@ -157,12 +157,12 @@ static NTSTATUS get_info3_from_wbcAuthUserInfo(TALLOC_CTX 
*mem_ctx,
 
        /* We already handled the first two, now take care of the rest */
        info3->base.groups.count = info->num_sids - 2;
-       for (i = 2, j = 0; i < info->num_sids; ++i, ++j) {
 
-               rids = talloc_array(mem_ctx, struct samr_RidWithAttribute,
-                                   info3->base.groups.count);
-               NT_STATUS_HAVE_NO_MEMORY(rids);
+       rids = talloc_array(mem_ctx, struct samr_RidWithAttribute,
+                           info3->base.groups.count);
+       NT_STATUS_HAVE_NO_MEMORY(rids);
 
+       for (i = 2, j = 0; i < info->num_sids; ++i, ++j) {
                rids[j].attributes = info->sids[i].attributes;
                dom_sid_split_rid(mem_ctx,
                                  (struct dom_sid2 *) &info->sids[i].sid,


-- 
Samba Shared Repository

Reply via email to