On Tue, 2009-09-22 at 00:16 +0200, Jelmer Vernooij wrote: > Hi Simo, > > Simo Sorce wrote: > > diff --git a/source4/lib/ldb/external/libtalloc.m4 > > b/source4/lib/ldb/external/libtalloc.m4 > > index a4c5b8a..b681541 100644 > > --- a/source4/lib/ldb/external/libtalloc.m4 > > +++ b/source4/lib/ldb/external/libtalloc.m4 > > @@ -4,4 +4,4 @@ AC_SUBST(TALLOC_LIBS) > > > > AC_CHECK_HEADER(talloc.h, > > [AC_CHECK_LIB(talloc, talloc_init, [TALLOC_LIBS="-ltalloc"]) ], > > - [PKG_CHECK_MODULES(TALLOC, talloc)]) > > + [PKG_CHECK_MODULES(TALLOC, talloc >= 2.0.0)]) > > > Can we perhaps reverse this test (trying with pkg-config before > attempting to link to -ltalloc) ? With the current order of things we'll > just find talloc using the first test and not actually see that what is > on the system is out of date.
Yes, I guess we can. Feel free to commit a change. Simo.
