On Mon, 2009-09-21 at 23:49 +0200, Jelmer Vernooij wrote: > Hi Andrew, Oliver, > > Sorry if this has already been fixed since.. > > Andrew Bartlett wrote: > > diff --git a/source4/scripting/python/samba/provision.py > > b/source4/scripting/python/samba/provision.py > > index 8a7ed6a..39c3fff 100644 > > --- a/source4/scripting/python/samba/provision.py > > +++ b/source4/scripting/python/samba/provision.py > > @@ -36,6 +36,7 @@ import socket > > import param > > import registry > > import samba > > +import subprocess > > from auth import system_session > > from samba import version, Ldb, substitute_var, valid_netbios_name, > > check_all_substituted, \ > > DS_BEHAVIOR_WIN2008 > subprocess is a relatively new Python package, depending on it would > mean that we can't support some of the older python versions that we > support at the moment (it's >= 2.4 IIRC). Do we really need one of the > features from subprocess or could we perhaps fall back to something > also present in older versions of Python (os.popen2?).
I'm quite happy with this. We handle the case where we can't call terminate() - a newer feature, and it seems to work on enough systems. Andrew Bartlett -- Andrew Bartlett http://samba.org/~abartlet/ Authentication Developer, Samba Team http://samba.org Samba Developer, Cisco Inc.
signature.asc
Description: This is a digitally signed message part
