Hi Matthias,
> yeah I know that my change is problematic. But I got a request from Günther
> to adapt the values as they're specified in "samr.idl" to allow further error
> case additions in winbind.
>
> In particular consider the value 0: previous it was an "other" error but a
> lookup in the MS-SAMR documentation pointed out that it should mean no error
> at all.
>
> So I'd strongly prefer to keep the patch in this form to have it right - from
> now on . I know it is cumbersome to break the API and external code has to be
> adapted - but personally I don't see a better solution.
I think we just need this, then it's fine:
#define WBC_PWD_CHANGE_REJECT_OTHER \
WBC_PWD_CHANGE_NO_ERROR
#define WBC_PWD_CHANGE_REJECT_TOO_SHORT \
WBC_PWD_CHANGE_PASSWORD_TOO_SHORT
#define WBC_PWD_CHANGE_REJECT_IN_HISTORY \
WBC_PWD_CHANGE_PWD_IN_HISTORY
#define WBC_PWD_CHANGE_REJECT_COMPLEXITY \
WBC_PWD_CHANGE_NOT_COMPLEX
metze
