The branch, master has been updated
via 14111d6... s4-selftest: skip two more scanners
via 2ff2c42... s4-torture: fixed a fd/mem leak in the RPC-LSA-SECRETS
test
via a1135b2... s4-selftest: skip the trans2.scan test
from 44a9989... s4-dsdb: fixed empty structure error on solaris8
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 14111d606b6b922f861f8fd291267b0b902755dc
Author: Andrew Tridgell <tri...@samba.org>
Date: Tue Oct 20 15:19:27 2009 +1100
s4-selftest: skip two more scanners
Protocol scanners are not any use in the build farm
commit 2ff2c421d0873a9433bced9d48e50aaad18c93d4
Author: Andrew Tridgell <tri...@samba.org>
Date: Tue Oct 20 14:27:57 2009 +1100
s4-torture: fixed a fd/mem leak in the RPC-LSA-SECRETS test
This test left a large number of lsa pipes open, which could trigger
the server running out of fds
commit a1135b28dcc15b0f1495a53ec8f6142605929bed
Author: Andrew Tridgell <tri...@samba.org>
Date: Tue Oct 20 13:54:55 2009 +1100
s4-selftest: skip the trans2.scan test
This test consumes a huge number of file descriptors on the server
(random binds to the WKSSVC pipe)
-----------------------------------------------------------------------
Summary of changes:
source4/selftest/skip | 3 +++
source4/torture/rpc/session_key.c | 19 ++++++++++++-------
2 files changed, 15 insertions(+), 7 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/selftest/skip b/source4/selftest/skip
index 2af200b..b9d9192 100644
--- a/source4/selftest/skip
+++ b/source4/selftest/skip
@@ -67,3 +67,6 @@ samba4.rap.scan # same thing here - we have docs now
samba4.gensec.python # not finished
bench # don't run benchmarks in our selftest
samba4.ldap.secdesc.python # this is expected to fail until the acl module is
complete
+trans2.scan # uses huge number of file descriptors
+base.scan.ioctl # bad idea in make test
+base.scan.pipe_number # bad idea in make test
diff --git a/source4/torture/rpc/session_key.c
b/source4/torture/rpc/session_key.c
index 431897a..1d31999 100644
--- a/source4/torture/rpc/session_key.c
+++ b/source4/torture/rpc/session_key.c
@@ -148,6 +148,7 @@ static bool test_secrets(struct torture_context *torture,
const void *_data)
struct dcerpc_binding *binding;
const struct secret_settings *settings =
(const struct secret_settings *)_data;
+ NTSTATUS status;
lp_set_cmdline(torture->lp_ctx, "ntlmssp client:keyexchange",
settings->keyexchange?"True":"False");
lp_set_cmdline(torture->lp_ctx, "ntlmssp_client:ntlm2",
settings->ntlm2?"True":"False");
@@ -158,24 +159,28 @@ static bool test_secrets(struct torture_context *torture,
const void *_data)
binding->flags |= settings->bindoptions;
- torture_assert_ntstatus_ok(torture,
- dcerpc_pipe_connect_b(torture, &p, binding,
- &ndr_table_lsarpc,
- cmdline_credentials,
- torture->ev,
- torture->lp_ctx),
- "connect");
+ status = dcerpc_pipe_connect_b(torture, &p, binding,
+ &ndr_table_lsarpc,
+ cmdline_credentials,
+ torture->ev,
+ torture->lp_ctx);
+
+ torture_assert_ntstatus_ok(torture, status, "connect");
if (!test_lsa_OpenPolicy2(p, torture, &handle)) {
+ talloc_free(p);
return false;
}
torture_assert(torture, handle, "OpenPolicy2 failed. This test cannot
run against this server");
if (!test_CreateSecret_basic(p, torture, handle)) {
+ talloc_free(p);
return false;
}
+ talloc_free(p);
+
return true;
}
--
Samba Shared Repository
