The branch, master has been updated
via ae1e949... s4:lsa RPC - Fix type of variable "atype"
via 7d5367f... s4:samr RPC - Use more LDB constants
via e8e76eb... s4:lsa RPC - Use more LDB constants
from e00281d... Implemented LDAP_SERVER_SD_FLAGS_OID on search requests.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit ae1e949810b3546807b5f88e366970263226d7e0
Author: Matthias Dieter Wallnöfer <[email protected]>
Date: Sat Nov 21 19:49:56 2009 +0100
s4:lsa RPC - Fix type of variable "atype"
This is an unsigned 32bit integer.
commit 7d5367fc99a559b19efed11c9c7a0f24c593606d
Author: Matthias Dieter Wallnöfer <[email protected]>
Date: Sat Nov 21 19:25:42 2009 +0100
s4:samr RPC - Use more LDB constants
commit e8e76eb83acaf3095d6acb9c930fc2d10396efd4
Author: Matthias Dieter Wallnöfer <[email protected]>
Date: Sat Nov 21 19:46:25 2009 +0100
s4:lsa RPC - Use more LDB constants
And fix an obvious bug (call of "samdb_msg_add_delete")
-----------------------------------------------------------------------
Summary of changes:
source4/rpc_server/lsa/dcesrv_lsa.c | 32 +++++++++++++++---------------
source4/rpc_server/lsa/lsa_lookup.c | 3 +-
source4/rpc_server/samr/dcesrv_samr.c | 6 ++--
source4/rpc_server/samr/samr_password.c | 18 ++++++++--------
4 files changed, 30 insertions(+), 29 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/rpc_server/lsa/dcesrv_lsa.c
b/source4/rpc_server/lsa/dcesrv_lsa.c
index 35e5d0f..9709520 100644
--- a/source4/rpc_server/lsa/dcesrv_lsa.c
+++ b/source4/rpc_server/lsa/dcesrv_lsa.c
@@ -192,7 +192,7 @@ static NTSTATUS dcesrv_lsa_DeleteObject(struct
dcesrv_call_state *dce_call, TALL
ret = ldb_delete(secret_state->sam_ldb,
secret_state->secret_dn);
talloc_free(h);
- if (ret != 0) {
+ if (ret != LDB_SUCCESS) {
return NT_STATUS_INVALID_HANDLE;
}
@@ -203,13 +203,13 @@ static NTSTATUS dcesrv_lsa_DeleteObject(struct
dcesrv_call_state *dce_call, TALL
struct lsa_trusted_domain_state *trusted_domain_state =
talloc_get_type(h->data, struct
lsa_trusted_domain_state);
ret =
ldb_transaction_start(trusted_domain_state->policy->sam_ldb);
- if (ret != 0) {
+ if (ret != LDB_SUCCESS) {
return NT_STATUS_INTERNAL_DB_CORRUPTION;
}
ret = ldb_delete(trusted_domain_state->policy->sam_ldb,
trusted_domain_state->trusted_domain_dn);
- if (ret != 0) {
+ if (ret != LDB_SUCCESS) {
ldb_transaction_cancel(trusted_domain_state->policy->sam_ldb);
return NT_STATUS_INVALID_HANDLE;
}
@@ -217,14 +217,14 @@ static NTSTATUS dcesrv_lsa_DeleteObject(struct
dcesrv_call_state *dce_call, TALL
if (trusted_domain_state->trusted_domain_user_dn) {
ret = ldb_delete(trusted_domain_state->policy->sam_ldb,
trusted_domain_state->trusted_domain_user_dn);
- if (ret != 0) {
+ if (ret != LDB_SUCCESS) {
ldb_transaction_cancel(trusted_domain_state->policy->sam_ldb);
return NT_STATUS_INVALID_HANDLE;
}
}
ret =
ldb_transaction_commit(trusted_domain_state->policy->sam_ldb);
- if (ret != 0) {
+ if (ret != LDB_SUCCESS) {
return NT_STATUS_INTERNAL_DB_CORRUPTION;
}
talloc_free(h);
@@ -2025,7 +2025,7 @@ static NTSTATUS dcesrv_lsa_AddRemoveAccountRights(struct
dcesrv_call_state *dce_
samdb_msg_add_string(state->pdb, msg, msg, "comment", "added
via LSA");
ret = ldb_add(state->pdb, msg);
}
- if (ret != 0) {
+ if (ret != LDB_SUCCESS) {
if (ldb_flag == LDB_FLAG_MOD_DELETE && ret ==
LDB_ERR_NO_SUCH_ATTRIBUTE) {
talloc_free(msg);
return NT_STATUS_OK;
@@ -2339,7 +2339,7 @@ static NTSTATUS dcesrv_lsa_CreateSecret(struct
dcesrv_call_state *dce_call, TALL
/* create the secret */
ret = ldb_add(secret_state->sam_ldb, msg);
- if (ret != 0) {
+ if (ret != LDB_SUCCESS) {
DEBUG(0,("Failed to create secret record %s: %s\n",
ldb_dn_get_linearized(msg->dn),
ldb_errstring(secret_state->sam_ldb)));
@@ -2529,13 +2529,13 @@ static NTSTATUS dcesrv_lsa_SetSecret(struct
dcesrv_call_state *dce_call, TALLOC_
/* set value */
if (samdb_msg_add_value(secret_state->sam_ldb,
- mem_ctx, msg, "priorValue", &val) != 0)
{
+ mem_ctx, msg, "priorValue", &val) !=
LDB_SUCCESS) {
return NT_STATUS_NO_MEMORY;
}
/* set old value mtime */
if (samdb_msg_add_uint64(secret_state->sam_ldb,
- mem_ctx, msg, "priorSetTime", nt_now)
!= 0) {
+ mem_ctx, msg, "priorSetTime", nt_now)
!= LDB_SUCCESS) {
return NT_STATUS_NO_MEMORY;
}
@@ -2585,12 +2585,12 @@ static NTSTATUS dcesrv_lsa_SetSecret(struct
dcesrv_call_state *dce_call, TALLOC_
/* set old value mtime */
if (ldb_msg_find_ldb_val(res[0], "lastSetTime")) {
if (samdb_msg_add_uint64(secret_state->sam_ldb,
- mem_ctx, msg, "priorSetTime",
last_set_time) != 0) {
+ mem_ctx, msg, "priorSetTime",
last_set_time) != LDB_SUCCESS) {
return NT_STATUS_NO_MEMORY;
}
} else {
if (samdb_msg_add_uint64(secret_state->sam_ldb,
- mem_ctx, msg, "priorSetTime",
nt_now) != 0) {
+ mem_ctx, msg, "priorSetTime",
nt_now) != LDB_SUCCESS) {
return NT_STATUS_NO_MEMORY;
}
}
@@ -2611,31 +2611,31 @@ static NTSTATUS dcesrv_lsa_SetSecret(struct
dcesrv_call_state *dce_call, TALLOC_
/* set value */
if (samdb_msg_add_value(secret_state->sam_ldb,
- mem_ctx, msg, "currentValue", &val) !=
0) {
+ mem_ctx, msg, "currentValue", &val) !=
LDB_SUCCESS) {
return NT_STATUS_NO_MEMORY;
}
/* set new value mtime */
if (samdb_msg_add_uint64(secret_state->sam_ldb,
- mem_ctx, msg, "lastSetTime", nt_now)
!= 0) {
+ mem_ctx, msg, "lastSetTime", nt_now)
!= LDB_SUCCESS) {
return NT_STATUS_NO_MEMORY;
}
} else {
/* NULL out the NEW value */
if (samdb_msg_add_uint64(secret_state->sam_ldb,
- mem_ctx, msg, "lastSetTime", nt_now)
!= 0) {
+ mem_ctx, msg, "lastSetTime", nt_now)
!= LDB_SUCCESS) {
return NT_STATUS_NO_MEMORY;
}
if (samdb_msg_add_delete(secret_state->sam_ldb,
- mem_ctx, msg, "currentValue")) {
+ mem_ctx, msg, "currentValue") !=
LDB_SUCCESS) {
return NT_STATUS_NO_MEMORY;
}
}
/* modify the samdb record */
ret = samdb_replace(secret_state->sam_ldb, mem_ctx, msg);
- if (ret != 0) {
+ if (ret != LDB_SUCCESS) {
/* we really need samdb.c to return NTSTATUS */
return NT_STATUS_UNSUCCESSFUL;
}
diff --git a/source4/rpc_server/lsa/lsa_lookup.c
b/source4/rpc_server/lsa/lsa_lookup.c
index a164ad6..b044eea 100644
--- a/source4/rpc_server/lsa/lsa_lookup.c
+++ b/source4/rpc_server/lsa/lsa_lookup.c
@@ -243,7 +243,8 @@ static NTSTATUS dcesrv_lsa_lookup_name(struct
tevent_context *ev_ctx,
struct dom_sid **sid, enum lsa_SidType
*rtype,
uint32_t *rid)
{
- int ret, atype, i;
+ int ret, i;
+ uint32_t atype;
struct ldb_message **res;
const char * const attrs[] = { "objectSid", "sAMAccountType", NULL};
const char *p;
diff --git a/source4/rpc_server/samr/dcesrv_samr.c
b/source4/rpc_server/samr/dcesrv_samr.c
index 0b102b5..725ecba 100644
--- a/source4/rpc_server/samr/dcesrv_samr.c
+++ b/source4/rpc_server/samr/dcesrv_samr.c
@@ -2679,7 +2679,7 @@ static NTSTATUS dcesrv_samr_DeleteDomAlias(struct
dcesrv_call_state *dce_call, T
a_state = h->data;
ret = ldb_delete(a_state->sam_ctx, a_state->account_dn);
- if (ret != 0) {
+ if (ret != LDB_SUCCESS) {
return NT_STATUS_UNSUCCESSFUL;
}
@@ -4048,10 +4048,10 @@ static NTSTATUS
dcesrv_samr_RemoveMemberFromForeignDomain(struct dcesrv_call_sta
}
if (samdb_msg_add_delval(d_state->sam_ctx, mem_ctx, mod,
- "member", memberdn) != 0)
+ "member", memberdn) != LDB_SUCCESS)
return NT_STATUS_NO_MEMORY;
- if (ldb_modify(d_state->sam_ctx, mod) != 0)
+ if (ldb_modify(d_state->sam_ctx, mod) != LDB_SUCCESS)
return NT_STATUS_UNSUCCESSFUL;
talloc_free(mod);
diff --git a/source4/rpc_server/samr/samr_password.c
b/source4/rpc_server/samr/samr_password.c
index faf95b1..1ed1dd1 100644
--- a/source4/rpc_server/samr/samr_password.c
+++ b/source4/rpc_server/samr/samr_password.c
@@ -67,7 +67,7 @@ NTSTATUS dcesrv_samr_ChangePasswordUser(struct
dcesrv_call_state *dce_call,
}
ret = ldb_transaction_start(sam_ctx);
- if (ret) {
+ if (ret != LDB_SUCCESS) {
DEBUG(1, ("Failed to start transaction: %s\n",
ldb_errstring(sam_ctx)));
return NT_STATUS_TRANSACTION_ABORTED;
}
@@ -154,7 +154,7 @@ NTSTATUS dcesrv_samr_ChangePasswordUser(struct
dcesrv_call_state *dce_call,
/* The above call only setup the modifications, this actually
* makes the write to the database. */
ret = samdb_replace(sam_ctx, mem_ctx, msg);
- if (ret != 0) {
+ if (ret != LDB_SUCCESS) {
DEBUG(2,("Failed to modify record to change password on %s:
%s\n",
ldb_dn_get_linearized(a_state->account_dn),
ldb_errstring(sam_ctx)));
@@ -164,7 +164,7 @@ NTSTATUS dcesrv_samr_ChangePasswordUser(struct
dcesrv_call_state *dce_call,
/* And this confirms it in a transaction commit */
ret = ldb_transaction_commit(sam_ctx);
- if (ret != 0) {
+ if (ret != LDB_SUCCESS) {
DEBUG(1,("Failed to commit transaction to change password on
%s: %s\n",
ldb_dn_get_linearized(a_state->account_dn),
ldb_errstring(sam_ctx)));
@@ -216,7 +216,7 @@ NTSTATUS dcesrv_samr_OemChangePasswordUser2(struct
dcesrv_call_state *dce_call,
}
ret = ldb_transaction_start(sam_ctx);
- if (ret) {
+ if (ret != LDB_SUCCESS) {
DEBUG(1, ("Failed to start transaction: %s\n",
ldb_errstring(sam_ctx)));
return NT_STATUS_TRANSACTION_ABORTED;
}
@@ -311,7 +311,7 @@ NTSTATUS dcesrv_samr_OemChangePasswordUser2(struct
dcesrv_call_state *dce_call,
/* The above call only setup the modifications, this actually
* makes the write to the database. */
ret = samdb_replace(sam_ctx, mem_ctx, mod);
- if (ret != 0) {
+ if (ret != LDB_SUCCESS) {
DEBUG(2,("Failed to modify record to change password on %s:
%s\n",
ldb_dn_get_linearized(user_dn),
ldb_errstring(sam_ctx)));
@@ -321,7 +321,7 @@ NTSTATUS dcesrv_samr_OemChangePasswordUser2(struct
dcesrv_call_state *dce_call,
/* And this confirms it in a transaction commit */
ret = ldb_transaction_commit(sam_ctx);
- if (ret != 0) {
+ if (ret != LDB_SUCCESS) {
DEBUG(1,("Failed to commit transaction to change password on
%s: %s\n",
ldb_dn_get_linearized(user_dn),
ldb_errstring(sam_ctx)));
@@ -369,7 +369,7 @@ NTSTATUS dcesrv_samr_ChangePasswordUser3(struct
dcesrv_call_state *dce_call,
}
ret = ldb_transaction_start(sam_ctx);
- if (ret) {
+ if (ret != LDB_SUCCESS) {
talloc_free(sam_ctx);
DEBUG(1, ("Failed to start transaction: %s\n",
ldb_errstring(sam_ctx)));
return NT_STATUS_TRANSACTION_ABORTED;
@@ -474,7 +474,7 @@ NTSTATUS dcesrv_samr_ChangePasswordUser3(struct
dcesrv_call_state *dce_call,
/* The above call only setup the modifications, this actually
* makes the write to the database. */
ret = samdb_replace(sam_ctx, mem_ctx, mod);
- if (ret != 0) {
+ if (ret != LDB_SUCCESS) {
DEBUG(2,("samdb_replace failed to change password for %s: %s\n",
ldb_dn_get_linearized(user_dn),
ldb_errstring(sam_ctx)));
@@ -484,7 +484,7 @@ NTSTATUS dcesrv_samr_ChangePasswordUser3(struct
dcesrv_call_state *dce_call,
/* And this confirms it in a transaction commit */
ret = ldb_transaction_commit(sam_ctx);
- if (ret != 0) {
+ if (ret != LDB_SUCCESS) {
DEBUG(1,("Failed to commit transaction to change password on
%s: %s\n",
ldb_dn_get_linearized(user_dn),
ldb_errstring(sam_ctx)));
--
Samba Shared Repository
