The branch, v3-5-test has been updated
       via  88d2eca3.. Add helpful debug of DACL for errors on ACL access. 
Jeremy. (cherry picked from commit b8c87c43dd9309b3d2fed5d5db5b38057a8e4e90)
      from  4c733f1... Ensure dos_mode can return FILE_ATTRIBUTE_NORMAL, then 
filter the returned attributes by protocol level.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test


- Log -----------------------------------------------------------------
commit 88d2eca3b3b305a569fdd56936c8a92ee5843e4b
Author: Jeremy Allison <[email protected]>
Date:   Wed Dec 16 10:09:11 2009 -0800

    Add helpful debug of DACL for errors on ACL access.
    Jeremy.
    (cherry picked from commit b8c87c43dd9309b3d2fed5d5db5b38057a8e4e90)

-----------------------------------------------------------------------

Summary of changes:
 source3/smbd/open.c |   12 ++++++++++--
 1 files changed, 10 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 9dc8320..120de0f 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -102,8 +102,6 @@ NTSTATUS smbd_check_open_rights(struct connection_struct 
*conn,
                                access_mask,
                                access_granted);
 
-       TALLOC_FREE(sd);
-
        DEBUG(10,("smbd_check_open_rights: file %s requesting "
                "0x%x returning 0x%x (%s)\n",
                smb_fname_str_dbg(smb_fname),
@@ -111,6 +109,16 @@ NTSTATUS smbd_check_open_rights(struct connection_struct 
*conn,
                (unsigned int)*access_granted,
                nt_errstr(status) ));
 
+       if (!NT_STATUS_IS_OK(status)) {
+               if (DEBUGLEVEL >= 10) {
+                       DEBUG(10,("smbd_check_open_rights: acl for %s is:\n",
+                               smb_fname_str_dbg(smb_fname) ));
+                       NDR_PRINT_DEBUG(security_descriptor, sd);
+               }
+       }
+
+       TALLOC_FREE(sd);
+
        return status;
 }
 


-- 
Samba Shared Repository

Reply via email to