The branch, v3-3-test has been updated via 1d61102... s3: Fix a crash in libsmbclient used against the OpenSolaris CIFS server from edc4431... Fix bug 7045 - Bad (non memory copying) interfaces in smbc_setXXXX calls.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test - Log ----------------------------------------------------------------- commit 1d611028433db18e96d946b206a8eed1048f9b26 Author: Volker Lendecke <v...@samba.org> Date: Sat Jan 16 13:31:44 2010 +0100 s3: Fix a crash in libsmbclient used against the OpenSolaris CIFS server A user has sent me a sniff where the OpenSolaris CIFS server returns "32" in totalentries, but the array in ctr only contains 15 entries. Look at the right delimiter for walking the array. Fix bug #7046 (libsmbclient crash against OpenSolaris CIFS server). ----------------------------------------------------------------------- Summary of changes: source/libsmb/libsmb_dir.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source/libsmb/libsmb_dir.c b/source/libsmb/libsmb_dir.c index b370f4b..845ee5e 100644 --- a/source/libsmb/libsmb_dir.c +++ b/source/libsmb/libsmb_dir.c @@ -303,7 +303,7 @@ net_share_enum_rpc(struct cli_state *cli, } /* For each returned entry... */ - for (i = 0; i < total_entries; i++) { + for (i = 0; i < info_ctr.ctr.ctr1->count; i++) { /* pull out the share name */ fstrcpy(name, info_ctr.ctr.ctr1->array[i].name); -- Samba Shared Repository