On 2009-11-01 at 11:18 +0100 Stefan (metze) Metzmacher sent off: > I think talloc and tdb should not get LIBREPLACE_NETWORK_LIBS > linked in... they don't include "system/network.h" from libreplace. > And the standalone builds also doesn't use LIBREPLACE_NETWORK at all.
even if unused, linking in object files that have unresolved symbols is bad manner. I think we could eliminate the dependency the clean way by splitting up LIBREPLACE_OBJ so that for example the libreplace network object files are only linked in when needed. But is it really worth doing that? > I think it's a bit confusing to have LIBREPLACE_LIBS as the same > as LIBREPLACE_NETWORK_LIBS. that's because the LIBREPLACE_NETWORK_LIBS are the only libs currently required by any part of libreplace. Using LIBREPLACE_LIBS inside samba's Makefle is straigt forward as long as we just have one single LIBREPLACE_OBJ blob. I think if the object files would be split up the old LIBREPLACE_NETWORK_LIBS would make ore sense again. Cheers Björn
pgp0Cf1UKEgUG.pgp
Description: PGP signature
