The branch, v3-4-test has been updated
       via  d983085... s3-net_conf: Display an error on net conf import 
failures.
      from  8dd1f92... s3-libsmbclient: Fix incomplete description of function 
return values in libsmbclient.h.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-4-test


- Log -----------------------------------------------------------------
commit d983085cee01fcf6e6176d395400075e6d5df937
Author: Jim McDonough <[email protected]>
Date:   Wed Apr 21 20:53:51 2010 +0200

    s3-net_conf: Display an error on net conf import failures.
    
    When something goes wrong, such as a typo in a parameter
    name, we'll now display the failure instead of just returning
    with -1 and no message.
    
    Fix bug #7378 ("net conf import" fails silently on parameter typo).

-----------------------------------------------------------------------

Summary of changes:
 source3/utils/net_conf.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/utils/net_conf.c b/source3/utils/net_conf.c
index 1dd8c1f..e30c0ab 100644
--- a/source3/utils/net_conf.c
+++ b/source3/utils/net_conf.c
@@ -209,6 +209,9 @@ static WERROR import_process_service(struct net_context *c,
                                                     service->param_names[idx],
                                                     
service->param_values[idx]);
                        if (!W_ERROR_IS_OK(werr)) {
+                               d_printf("Error in section [%s], parameter 
\"%s\": %s\n",
+                                        service->name, 
service->param_names[idx],
+                                        win_errstr(werr));
                                goto done;
                        }
                }


-- 
Samba Shared Repository

Reply via email to