The branch, master has been updated via 6beba78... Fix crash when rescheduling oplock open. from abdb96b... s3: Implement "net rpc user setprimarygroup"
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit 6beba782f1bf951236813e0b46115b8102212c03 Author: Jeremy Allison <j...@samba.org> Date: Mon Apr 26 10:54:33 2010 -0700 Fix crash when rescheduling oplock open. Jeremy. ----------------------------------------------------------------------- Summary of changes: source3/smbd/smb2_create.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/smbd/smb2_create.c b/source3/smbd/smb2_create.c index 6a118c3..3302730 100644 --- a/source3/smbd/smb2_create.c +++ b/source3/smbd/smb2_create.c @@ -981,6 +981,15 @@ void schedule_deferred_open_message_smb2(uint64_t mid) /* Ensure we don't have any outstanding timer event. */ TALLOC_FREE(state->te); + /* + * This is subtle. We must null out the callback + * before resheduling, else the first call to + * tevent_req_nterror() causes the _receive() + * function to be called, this causing tevent_req_post() + * to crash. + */ + tevent_req_set_callback(smb2req->subreq, NULL, NULL); + im = tevent_create_immediate(smb2req); if (!im) { smbd_server_connection_terminate(smb2req->sconn, -- Samba Shared Repository