The branch, master has been updated
       via  7f8b3a2... s4-smbtorture: Fix test_SetPrinterDataEx_keys and 
test_SetPrinterDataEx_values.
      from  26a9546... s4:operational LDB module - fix a misleading comment

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 7f8b3a26ecb657bb3c818f2b295648a56c093788
Author: Günther Deschner <g...@samba.org>
Date:   Wed Jun 23 10:47:01 2010 +0200

    s4-smbtorture: Fix test_SetPrinterDataEx_keys and 
test_SetPrinterDataEx_values.
    
    We want to continue, not to skip here.
    
    Guenther

-----------------------------------------------------------------------

Summary of changes:
 source4/torture/rpc/spoolss.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/torture/rpc/spoolss.c b/source4/torture/rpc/spoolss.c
index a797e24..930556e 100644
--- a/source4/torture/rpc/spoolss.c
+++ b/source4/torture/rpc/spoolss.c
@@ -4841,9 +4841,9 @@ static bool test_SetPrinterDataEx_keys(struct 
torture_context *tctx,
                        char *q;
                        q = strrchr(keys[i], '\\');
                        if (q) {
-                               torture_skip(tctx,
-                                       talloc_asprintf(tctx, "skipping keyname 
'%s' including '\\' character against Samba3\n",
-                                               keys[i]));
+                               torture_comment(tctx, "skipping keyname '%s' 
including '\\' character against Samba3\n",
+                                               keys[i]);
+                               continue;
                        }
                }
 
@@ -4946,9 +4946,9 @@ static bool test_SetPrinterDataEx_values(struct 
torture_context *tctx,
                        char *q;
                        q = strrchr(values[i], ',');
                        if (q) {
-                               torture_skip(tctx,
-                                       talloc_asprintf(tctx, "skipping 
valuename '%s' including ',' character against Samba3\n",
-                                               values[i]));
+                               torture_comment(tctx, "skipping valuename '%s' 
including ',' character against Samba3\n",
+                                               values[i]);
+                               continue;
                        }
                }
 


-- 
Samba Shared Repository

Reply via email to