The branch, v3-5-test has been updated via f1f260c s3: Fix bug 7470 from ca69f96 WHATSNEW: Update changes since 3.5.5.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test - Log ----------------------------------------------------------------- commit f1f260c018bfb5b2269731bb806176da1db12db8 Author: Volker Lendecke <v...@samba.org> Date: Sat Sep 25 10:56:58 2010 -0700 s3: Fix bug 7470 S_IREAD and S_IWRITE are not standard. Thanks to Joachim Schmitz <schm...@hp.com> for reporting! ----------------------------------------------------------------------- Summary of changes: source3/registry/reg_api.c | 2 +- source3/utils/net_rpc_registry.c | 3 ++- source3/utils/profiles.c | 3 ++- 3 files changed, 5 insertions(+), 3 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/registry/reg_api.c b/source3/registry/reg_api.c index 9aff4b0..b02481e 100644 --- a/source3/registry/reg_api.c +++ b/source3/registry/reg_api.c @@ -953,7 +953,7 @@ static WERROR backup_registry_key(struct registry_key_handle *krecord, /* open the registry file....fail if the file already exists */ regfile = regfio_open(fname, (O_RDWR|O_CREAT|O_EXCL), - (S_IREAD|S_IWRITE)); + (S_IRUSR|S_IWUSR)); if (regfile == NULL) { DEBUG(0,("backup_registry_key: failed to open \"%s\" (%s)\n", fname, strerror(errno) )); diff --git a/source3/utils/net_rpc_registry.c b/source3/utils/net_rpc_registry.c index fb9d80b..8f1a10d 100644 --- a/source3/utils/net_rpc_registry.c +++ b/source3/utils/net_rpc_registry.c @@ -1150,7 +1150,8 @@ static int rpc_registry_copy(struct net_context *c, int argc, const char **argv d_printf(_("ok\n")); d_printf(_("Opening %s...."), argv[1]); - if ( !(outfile = regfio_open( argv[1], (O_RDWR|O_CREAT|O_TRUNC), (S_IREAD|S_IWRITE) )) ) { + if ( !(outfile = regfio_open( argv[1], (O_RDWR|O_CREAT|O_TRUNC), + (S_IRUSR|S_IWUSR) )) ) { d_fprintf(stderr, _("Failed to open %s for writing\n"),argv[1]); goto out; } diff --git a/source3/utils/profiles.c b/source3/utils/profiles.c index 0dc9aca..eeaf2d2 100644 --- a/source3/utils/profiles.c +++ b/source3/utils/profiles.c @@ -275,7 +275,8 @@ int main( int argc, char *argv[] ) exit (1); } - if ( !(outfile = regfio_open( new_filename, (O_RDWR|O_CREAT|O_TRUNC), (S_IREAD|S_IWRITE) )) ) { + if ( !(outfile = regfio_open( new_filename, (O_RDWR|O_CREAT|O_TRUNC), + (S_IRUSR|S_IWUSR) )) ) { fprintf( stderr, "Failed to open new file %s!\n", new_filename ); fprintf( stderr, "Error was (%s)\n", strerror(errno) ); exit (1); -- Samba Shared Repository