On Mon, 2010-11-08 at 12:22 +0100, Matthias Dieter Wallnöfer wrote:
> @@ -1441,7 +1442,13 @@ static int py_ldb_contains(PyLdbObject *self, PyObject 
> *obj)
>  
>       talloc_free(result);
>  
> -     return count;
> +     if (count == 1) {
> +             return 1;
> +     } else if (count == 0) {
> +             return 0;
> +     }
> +
> +     return -1;
>  }
>  
>  static PySequenceMethods py_ldb_seq = {
^^ This is wrong. This means we'll not set an exception and return -1 if
count is more than one.

As I've said earlier I think the risk of these fixes is higher than the
(purely theoretical) gain. 

Cheers,

Jelmer

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to