The branch, v3-5-test has been updated
       via  bdebae1 s3:winbind: fix bug #7894 - sporadic winbind panic in rpc 
query_user_list
      from  8d9ef26 Fix bug #7892 - open_file_fchmod() leaves a stale lock.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test


- Log -----------------------------------------------------------------
commit bdebae14aa646dd9f969db5b3d1aa25c971c9381
Author: Michael Adam <[email protected]>
Date:   Thu Dec 30 11:12:42 2010 +0100

    s3:winbind: fix bug #7894 - sporadic winbind panic in rpc query_user_list
    
    correctly evaluate return code of rpccli_samr_QueryDisplayInfo()
    before accessing results.

-----------------------------------------------------------------------

Summary of changes:
 source3/winbindd/winbindd_rpc.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/winbindd/winbindd_rpc.c b/source3/winbindd/winbindd_rpc.c
index 599c888..b65b126 100644
--- a/source3/winbindd/winbindd_rpc.c
+++ b/source3/winbindd/winbindd_rpc.c
@@ -84,6 +84,13 @@ static NTSTATUS query_user_list(struct winbindd_domain 
*domain,
                                                      &total_size,
                                                      &returned_size,
                                                      &disp_info);
+
+               if (!NT_STATUS_IS_OK(result)) {
+                       if (!NT_STATUS_EQUAL(result, STATUS_MORE_ENTRIES)) {
+                               return result;
+                       }
+               }
+
                num_dom_users = disp_info.info1.count;
                start_idx += disp_info.info1.count;
                loop_count++;


-- 
Samba Shared Repository

Reply via email to