Hi Matthias, On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote: > - Log ----------------------------------------------------------------- > commit c678563efec82e84c9c86309cbf9495950a02b8c > Author: Matthias Dieter Wallnöfer <[email protected]> > Date: Sat Apr 17 20:08:15 2010 +0200 > > s4:kdc/db-glue.c - use "TALLOC_FREE" insteal of "talloc_free" for the > "priv" context > > Also after a free "priv" could be != NULL and may be freed again. > This should fix bug #7365. We tend to avoid TALLOC_FREE in Samba 4, opting for explicitly setting variable to NULL explicitly. This way valgrind will tell us about double frees.
If you think we should consider using TALLOC_FREE, I think we should discuss that first - for now, please use talloc_free() and assignments to NULL. Cheers, Jelmer
