The branch, master has been updated
       via  68a8c58 s3: Add debug level 0 warnings to make_new_server_info_guest
       via  51567de s3: Fix the return of make_new_server_info_guest
      from  207a84d s3-winbind: Fix paranoia checks in winbindd_samr.c.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 68a8c58d12e7dcbc06ac0f9693adb2c7646c84ac
Author: Volker Lendecke <[email protected]>
Date:   Wed Jun 15 14:08:23 2011 +0200

    s3: Add debug level 0 warnings to make_new_server_info_guest
    
    I've got a backtrace where this must have failed, but it is not clear why. 
If
    this fails, we should really complain because we can't start up.
    
    Autobuild-User: Volker Lendecke <[email protected]>
    Autobuild-Date: Wed Jun 15 15:20:49 CEST 2011 on sn-devel-104

commit 51567de6d7d91f727a2135cd2d5434f85db6d45a
Author: Volker Lendecke <[email protected]>
Date:   Wed Jun 15 14:09:50 2011 +0200

    s3: Fix the return of make_new_server_info_guest

-----------------------------------------------------------------------

Summary of changes:
 source3/auth/auth_util.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/auth/auth_util.c b/source3/auth/auth_util.c
index 1b986a0..64c290e 100644
--- a/source3/auth/auth_util.c
+++ b/source3/auth/auth_util.c
@@ -773,6 +773,8 @@ static NTSTATUS make_new_server_info_guest(struct 
auth_serversupplied_info **ses
 
        status = get_guest_info3(tmp_ctx, &info3);
        if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(0, ("get_guest_info3 failed with %s\n",
+                         nt_errstr(status)));
                goto done;
        }
 
@@ -782,6 +784,8 @@ static NTSTATUS make_new_server_info_guest(struct 
auth_serversupplied_info **ses
                                        &server_info,
                                        &info3);
        if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(0, ("make_server_info_info3 failed with %s\n",
+                         nt_errstr(status)));
                goto done;
        }
 
@@ -793,8 +797,8 @@ static NTSTATUS make_new_server_info_guest(struct 
auth_serversupplied_info **ses
        status = create_local_token(tmp_ctx, server_info, NULL, session_info);
        TALLOC_FREE(server_info);
        if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(10, ("create_local_token failed: %s\n",
-                          nt_errstr(status)));
+               DEBUG(0, ("create_local_token failed: %s\n",
+                         nt_errstr(status)));
                goto done;
        }
        talloc_steal(NULL, *session_info);
@@ -811,7 +815,7 @@ static NTSTATUS make_new_server_info_guest(struct 
auth_serversupplied_info **ses
        status = NT_STATUS_OK;
 done:
        TALLOC_FREE(tmp_ctx);
-       return NT_STATUS_OK;
+       return status;
 }
 
 /***************************************************************************


-- 
Samba Shared Repository

Reply via email to