The branch, master has been updated via f9601a9 s3:sharesec: return an error if get_share_security() returns NULL from 93ad34c s3:test: catch more errors in test_access_check() in the smbclient_s3 test
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit f9601a91805651963834e37e27800a74931468b7 Author: Stefan Metzmacher <me...@samba.org> Date: Wed Jul 6 12:31:41 2011 +0200 s3:sharesec: return an error if get_share_security() returns NULL This indicates an error, as it uses get_share_security_default() if no security descriptor is configured. Jeremy, please check. metze Autobuild-User: Stefan Metzmacher <me...@samba.org> Autobuild-Date: Wed Jul 6 15:40:23 CEST 2011 on sn-devel-104 ----------------------------------------------------------------------- Summary of changes: source3/lib/sharesec.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/lib/sharesec.c b/source3/lib/sharesec.c index 66e3401..2f62535 100644 --- a/source3/lib/sharesec.c +++ b/source3/lib/sharesec.c @@ -426,7 +426,7 @@ bool share_access_check(const struct security_token *token, if (pgranted != NULL) { *pgranted = desired_access; } - return True; + return false; } status = se_access_check(psd, token, desired_access, &granted); -- Samba Shared Repository