The branch, master has been updated
via 81b4db7 s3 libaddns: Prevent a crash when dns_create_update fails
from b16f539 s4-dns: added --no-credentials option to samba_dnsupdate
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 81b4db74a704fbc57e7fed8b8a75fc6de18a4e8d
Author: Kai Blin <[email protected]>
Date: Tue Nov 22 11:26:04 2011 +0100
s3 libaddns: Prevent a crash when dns_create_update fails
When dns_create_update() fails, it does not initialize *req, and then
TALLOC_FREE(req) in the
error handling crashes if we're lucky.
Instead of going into the generic error handling, treat the failure in
dns_create_update() like
dns_create_update_request() and just pass on the error.
Thanks to Harry Mason for reporting this issue.
Autobuild-User: Kai Blin <[email protected]>
Autobuild-Date: Tue Nov 22 14:29:07 CET 2011 on sn-devel-104
-----------------------------------------------------------------------
Summary of changes:
lib/addns/dnsrecord.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/lib/addns/dnsrecord.c b/lib/addns/dnsrecord.c
index 045fd46..de70bca 100644
--- a/lib/addns/dnsrecord.c
+++ b/lib/addns/dnsrecord.c
@@ -377,7 +377,7 @@ DNS_ERROR dns_create_probe(TALLOC_CTX *mem_ctx, const char
*zone,
uint16 i;
err = dns_create_update(mem_ctx, zone, &req);
- if (!ERR_DNS_IS_OK(err)) goto error;
+ if (!ERR_DNS_IS_OK(err)) return err;
err = dns_create_name_not_in_use_record(req, host, QTYPE_CNAME, &rec);
if (!ERR_DNS_IS_OK(err)) goto error;
--
Samba Shared Repository
