The branch, master has been updated
via 9e25361 tevent_signal: Fix a valgrind error
from 740d4d7 s3: files_struct->mode is only written, remove it
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 9e25361203155c25d5deee4acd1fce638808cdbf
Author: Volker Lendecke <[email protected]>
Date: Wed Feb 15 16:17:34 2012 +0100
tevent_signal: Fix a valgrind error
This fixes an uninitialized read introduced by my fix for the tevent_signal
destructors. From looking at the code you might believe that this kicks in
only
when talloc failed. But with -O3 I do see it in normal operations.
Sorry for that.
Autobuild-User: Volker Lendecke <[email protected]>
Autobuild-Date: Wed Feb 15 17:58:37 CET 2012 on sn-devel-104
-----------------------------------------------------------------------
Summary of changes:
lib/tevent/tevent_signal.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/lib/tevent/tevent_signal.c b/lib/tevent/tevent_signal.c
index 248dd35..77ef7b0 100644
--- a/lib/tevent/tevent_signal.c
+++ b/lib/tevent/tevent_signal.c
@@ -346,6 +346,8 @@ int tevent_common_check_signal(struct tevent_context *ev)
struct tevent_signal *se = sl->se;
struct tevent_se_exists *exists;
+ next = sl->next;
+
/*
* We have to be careful to not touch "se"
* after it was deleted in its handler. Thus
@@ -361,7 +363,6 @@ int tevent_common_check_signal(struct tevent_context *ev)
talloc_set_destructor(
exists, tevent_se_exists_destructor);
- next = sl->next;
#ifdef SA_SIGINFO
if (se->sa_flags & SA_SIGINFO) {
uint32_t j;
--
Samba Shared Repository
