The branch, master has been updated via f260596 nsstest: Allocate the correct sized buffer for initgroups via 8c3bbc0 selftest: test member server tests in security=ads from 3cd7fda build: Add libbsd as a dep for LIBREPLACE_HOSTCC
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit f260596206882a085fd43e5204acaecde72c3bab Author: Andrew Bartlett <abart...@samba.org> Date: Mon Feb 20 13:46:29 2012 +1100 nsstest: Allocate the correct sized buffer for initgroups Found by chance due to a re-order of the tests to start s3member earlier and chasing down a malloc Abort into a valgrind error. Only happens when a user has more than 4 groups. Andrew Bartlett Autobuild-User: Andrew Bartlett <abart...@samba.org> Autobuild-Date: Mon Feb 20 05:23:04 CET 2012 on sn-devel-104 commit 8c3bbc09795937f359cbfee027821a4648b7d941 Author: Andrew Bartlett <abart...@samba.org> Date: Mon Feb 13 12:16:07 2012 +1100 selftest: test member server tests in security=ads By testing more things against s3member (which is security=ads against samba4) we can improve our test coverage. Andrew Bartlett ----------------------------------------------------------------------- Summary of changes: nsswitch/nsstest.c | 2 +- source3/selftest/tests.py | 26 +++++++++++++------------- 2 files changed, 14 insertions(+), 14 deletions(-) Changeset truncated at 500 lines: diff --git a/nsswitch/nsstest.c b/nsswitch/nsstest.c index d84e028..e2b39bc 100644 --- a/nsswitch/nsstest.c +++ b/nsswitch/nsstest.c @@ -370,7 +370,7 @@ static void nss_test_initgroups(char *name, gid_t gid) int i; NSS_STATUS status; - groups = (gid_t *)malloc(size); + groups = (gid_t *)malloc(sizeof(gid_t) * size); groups[0] = gid; status = nss_initgroups(name, gid, &groups, &start, &size); diff --git a/source3/selftest/tests.py b/source3/selftest/tests.py index c52f616..3f8dcc1 100755 --- a/source3/selftest/tests.py +++ b/source3/selftest/tests.py @@ -123,26 +123,26 @@ tests=["--ping", "--separator", "--allocate-uid", "--allocate-gid"] -for t in tests: - plantestsuite("samba3.wbinfo_s3.(s3dc:local).%s" % t, "s3dc:local", [os.path.join(samba3srcdir, "script/tests/test_wbinfo_s3.sh"), t]) - plantestsuite("samba3.wbinfo_s3.(member:local).%s" % t, "member:local", [os.path.join(samba3srcdir, "script/tests/test_wbinfo_s3.sh"), t]) - -plantestsuite( - "samba3.wbinfo_sids2xids.(member:local)", "member:local", - [os.path.join(samba3srcdir, "script/tests/test_wbinfo_sids2xids.sh")]) +for env in ["s3dc", "member", "s3member"]: + plantestsuite("samba3.blackbox.smbclient_auth.plain (%s)" % env, env, [os.path.join(samba3srcdir, "script/tests/test_smbclient_auth.sh"), '$SERVER', '$SERVER_IP', '$DC_USERNAME', '$DC_PASSWORD', binpath('smbclient3'), configuration]) -plantestsuite("samba3.ntlm_auth.(s3dc:local)", "s3dc:local", [os.path.join(samba3srcdir, "script/tests/test_ntlm_auth_s3.sh"), valgrindify(python), samba3srcdir, binpath('ntlm_auth3'), configuration]) + for t in tests: + plantestsuite("samba3.wbinfo_s3.(%s:local).%s" % (env, t), "%s:local" % env, [os.path.join(samba3srcdir, "script/tests/test_wbinfo_s3.sh"), t]) -for env in ["s3dc", "member"]: - plantestsuite("samba3.blackbox.smbclient_auth.plain (%s)" % env, env, [os.path.join(samba3srcdir, "script/tests/test_smbclient_auth.sh"), '$SERVER', '$SERVER_IP', '$DC_USERNAME', '$DC_PASSWORD', binpath('smbclient3'), configuration]) + plantestsuite( + "samba3.wbinfo_sids2xids.(%s:local)" % env, "%s:local" % env, + [os.path.join(samba3srcdir, "script/tests/test_wbinfo_sids2xids.sh")]) + plantestsuite( "samba3.ntlm_auth.diagnostics(%s:local)" % env, "%s:local" % env, [os.path.join(samba3srcdir, "script/tests/test_ntlm_auth_diagnostics.sh"), binpath('ntlm_auth3'), '$DOMAIN', '$DC_USERNAME', '$DC_PASSWORD', configuration]) +plantestsuite("samba3.ntlm_auth.(s3dc:local)", "s3dc:local", [os.path.join(samba3srcdir, "script/tests/test_ntlm_auth_s3.sh"), valgrindify(python), samba3srcdir, binpath('ntlm_auth3'), configuration]) + for env in ["secserver"]: plantestsuite("samba3.blackbox.smbclient_auth.plain (%s) domain creds" % env, env, [os.path.join(samba3srcdir, "script/tests/test_smbclient_auth.sh"), '$SERVER', '$SERVER_IP', '$DOMAIN\\\\$DC_USERNAME', '$DC_PASSWORD', binpath('smbclient3'), configuration + " --option=clientntlmv2auth=no"]) -for env in ["member"]: +for env in ["member", "s3member"]: plantestsuite("samba3.blackbox.smbclient_auth.plain (%s) member creds" % env, env, [os.path.join(samba3srcdir, "script/tests/test_smbclient_auth.sh"), '$SERVER', '$SERVER_IP', '$SERVER\\\\$USERNAME', '$PASSWORD', binpath('smbclient3'), configuration]) for env in ["maptoguest", "secshare", "secserver"]: @@ -155,13 +155,13 @@ plantestsuite("samba3.blackbox.smbclient_auth.plain (%s) bad username" % env, en for env in ["s3dc"]: plantestsuite("samba3.blackbox.smbclient_s3.plain (%s)" % env, env, [os.path.join(samba3srcdir, "script/tests/test_smbclient_s3.sh"), '$SERVER', '$SERVER_IP', '$DOMAIN', '$DC_USERNAME', '$DC_PASSWORD', '$USERID', '$LOCAL_PATH', '$PREFIX', binpath('smbclient3'), binpath('wbinfo'), configuration]) -for env in ["member"]: +for env in ["member", "s3member"]: plantestsuite("samba3.blackbox.smbclient_s3.plain (%s) member creds" % env, env, [os.path.join(samba3srcdir, "script/tests/test_smbclient_s3.sh"), '$SERVER', '$SERVER_IP', '$SERVER', '$SERVER\\\\$USERNAME', '$PASSWORD', '$USERID', '$LOCAL_PATH', '$PREFIX', binpath('smbclient3'), binpath('wbinfo'), configuration]) for env in ["s3dc"]: plantestsuite("samba3.blackbox.smbclient_s3.sign (%s)" % env, env, [os.path.join(samba3srcdir, "script/tests/test_smbclient_s3.sh"), '$SERVER', '$SERVER_IP', '$DOMAIN', '$DC_USERNAME', '$DC_PASSWORD', '$USERID', '$LOCAL_PATH', '$PREFIX', binpath('smbclient3'), binpath('wbinfo'), configuration, "--signing=required"]) -for env in ["member"]: +for env in ["member", "s3member"]: plantestsuite("samba3.blackbox.smbclient_s3.sign (%s) member creds" % env, env, [os.path.join(samba3srcdir, "script/tests/test_smbclient_s3.sh"), '$SERVER', '$SERVER_IP', '$SERVER', '$SERVER\\\\$USERNAME', '$PASSWORD', '$USERID', '$LOCAL_PATH', '$PREFIX', binpath('smbclient3'), binpath('wbinfo'), configuration, "--signing=required"]) # encrypted -- Samba Shared Repository