The branch, master has been updated
via b1cedbb SEGV in acl_validate_spn_value: dnsHostName NULL
from 95976d4 selftest: Rework samba4.blackbox.bogusdomain to use a
temporary user
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit b1cedbbeea14e67cbce32d6ab152c6c5413ba7d8
Author: Arvid Requate <[email protected]>
Date: Fri Mar 2 13:59:30 2012 +0100
SEGV in acl_validate_spn_value: dnsHostName NULL
This patch addresses a segfault in acl_validate_spn_value which occurs
when the "dnsHostName" attribute is missing. This seems to be the case
in domains migrated with samba3upgrade. Looks similar to MS KB 817543.
Signed-off-by: Nadezhda Ivanova <nivanova@drizzit.(none)>
Autobuild-User: Nadezhda Ivanova <[email protected]>
Autobuild-Date: Fri Mar 2 21:26:40 CET 2012 on sn-devel-104
-----------------------------------------------------------------------
Summary of changes:
source4/dsdb/samdb/ldb_modules/acl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/dsdb/samdb/ldb_modules/acl.c
b/source4/dsdb/samdb/ldb_modules/acl.c
index abde85f..6aed682 100644
--- a/source4/dsdb/samdb/ldb_modules/acl.c
+++ b/source4/dsdb/samdb/ldb_modules/acl.c
@@ -516,7 +516,7 @@ static int acl_validate_spn_value(TALLOC_CTX *mem_ctx,
if (strlen(instanceName) == (strlen(samAccountName) - 1)
&& strncasecmp(instanceName, samAccountName, strlen(samAccountName)
- 1) == 0) {
goto success;
- } else if (strcasecmp(instanceName, dnsHostName) == 0) {
+ } else if (dnsHostName != NULL && strcasecmp(instanceName, dnsHostName)
== 0) {
goto success;
} else if (is_dc) {
const char *guid_str;
--
Samba Shared Repository
