The branch, master has been updated via bf38a5d Avoid all(), as it's not available in Python 2.4. from 39076c5 build: Remove all references to libuuid
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit bf38a5df5b69d41e4fa5fff7cb4447a5155058ce Author: Jelmer Vernooij <jel...@samba.org> Date: Sun May 27 14:17:52 2012 +0200 Avoid all(), as it's not available in Python 2.4. Autobuild-User: Jelmer Vernooij <jel...@samba.org> Autobuild-Date: Sun May 27 16:13:34 CEST 2012 on sn-devel-104 ----------------------------------------------------------------------- Summary of changes: source4/scripting/python/samba/__init__.py | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/scripting/python/samba/__init__.py b/source4/scripting/python/samba/__init__.py index 6ffd2a3..23c6ed7 100644 --- a/source4/scripting/python/samba/__init__.py +++ b/source4/scripting/python/samba/__init__.py @@ -302,12 +302,16 @@ MAX_NETBIOS_NAME_LEN = 15 def is_valid_netbios_char(c): return (c.isalnum() or c in " !#$%&'()-.@^_{}~") + def valid_netbios_name(name): """Check whether a name is valid as a NetBIOS name. """ # See crh's book (1.4.1.1) if len(name) > MAX_NETBIOS_NAME_LEN: return False - return all([is_valid_netbios_char(x) for x in name]) + for x in name: + if not is_valid_netbios_char(x): + return False + return True def import_bundled_package(modulename, location): -- Samba Shared Repository