The branch, master has been updated
       via  e1a4d3c s3: Fix Coverity ID 709049 Dereference before null check
      from  c2094e3 debug: Do not constantly rename logs when max log size = 0

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit e1a4d3cdd455616a9c6cb0cff543de2b5fdc2766
Author: Volker Lendecke <v...@samba.org>
Date:   Mon Jun 11 10:35:38 2012 +0200

    s3: Fix Coverity ID 709049 Dereference before null check
    
    We have dereferenced fsp before. Because smb2 is only handle based,
    this is a bogus check.
    
    Signed-off-by: Stefan Metzmacher <me...@samba.org>
    
    Autobuild-User(master): Stefan Metzmacher <me...@samba.org>
    Autobuild-Date(master): Mon Jun 11 15:30:54 CEST 2012 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/smbd/smb2_getinfo.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/smb2_getinfo.c b/source3/smbd/smb2_getinfo.c
index 1e0f24c..076cc55 100644
--- a/source3/smbd/smb2_getinfo.c
+++ b/source3/smbd/smb2_getinfo.c
@@ -316,7 +316,7 @@ static struct tevent_req *smbd_smb2_getinfo_send(TALLOC_CTX 
*mem_ctx,
 
                        /* We know this name is ok, it's already passed the 
checks. */
 
-               } else if (fsp && fsp->fh->fd == -1) {
+               } else if (fsp->fh->fd == -1) {
                        /*
                         * This is actually a QFILEINFO on a directory
                         * handle (returned from an NT SMB). NT5.0 seems


-- 
Samba Shared Repository

Reply via email to