The branch, v3-6-test has been updated
       via  e5b4ac7 Fix bug 9633: recursive mget should continue on EPERM
      from  292504a s3:auth: wbcAuthenticateEx gives unix times (bug #9625)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test


- Log -----------------------------------------------------------------
commit e5b4ac7978213acf7517b6852f7750e41cad787a
Author: David Disseldorp <[email protected]>
Date:   Mon Feb 4 19:04:39 2013 +0100

    Fix bug 9633: recursive mget should continue on EPERM
    
    Regression introduced by 14ff2e8de9bd8d0064762234555260f5eea643fe.
    When downloading files recursively, smbclient halts if it encounters
    a folder to which it does not have permission to traverse.

-----------------------------------------------------------------------

Summary of changes:
 source3/client/client.c |   13 +++++++++++--
 1 files changed, 11 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/client/client.c b/source3/client/client.c
index 58115ad..f6e42f6 100644
--- a/source3/client/client.c
+++ b/source3/client/client.c
@@ -1307,8 +1307,17 @@ static NTSTATUS do_mget(struct cli_state *cli_state, 
struct file_info *finfo,
                return NT_STATUS_NO_MEMORY;
        }
 
-       status = do_list(mget_mask, FILE_ATTRIBUTE_SYSTEM | 
FILE_ATTRIBUTE_HIDDEN | FILE_ATTRIBUTE_DIRECTORY,do_mget,false, true);
-       if (!NT_STATUS_IS_OK(status)) {
+       status = do_list(mget_mask,
+                        (FILE_ATTRIBUTE_SYSTEM
+                         | FILE_ATTRIBUTE_HIDDEN
+                         | FILE_ATTRIBUTE_DIRECTORY),
+                        do_mget, false, true);
+       if (!NT_STATUS_IS_OK(status)
+        && !NT_STATUS_EQUAL(status, NT_STATUS_ACCESS_DENIED)) {
+               /*
+                * Ignore access denied errors to ensure all permitted files are
+                * pulled down.
+                */
                return status;
        }
 


-- 
Samba Shared Repository

Reply via email to