[SCM] Samba Shared Repository - branch master updated

[Jeremy Allison]

The branch, master has been updated
       via  40d783c Call smb_panic when we try to exit the server uncleanly. 
This gives us the normal traceback and memory dump, but also runs the normal 
panic action.
       via  1dcd75d auth/ntlmssp: Avoid use-after-free of user_info after logon 
failure at log level 5
      from  e865788 dbwrap: Add a comment explaining a restriction

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 40d783c397ea21d03d1ea7130a438dd8c0d817f1
Author: Richard Sharpe <realrichardsha...@gmail.com>
Date:   Tue Mar 26 20:17:11 2013 -0700

    Call smb_panic when we try to exit the server uncleanly. This gives us the 
normal traceback and memory dump, but also runs the normal panic action.
    
    Signed-off-by: Richard Sharpe <realrichardsha...@gmail.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>
    
    Autobuild-User(master): Jeremy Allison <j...@samba.org>
    Autobuild-Date(master): Wed Mar 27 22:58:37 CET 2013 on sn-devel-104

commit 1dcd75df4941d7032a66d3fbb86ac76964444a3f
Author: Andrew Bartlett <abart...@samba.org>
Date:   Fri Mar 15 13:00:55 2013 +1100

    auth/ntlmssp: Avoid use-after-free of user_info after logon failure at log 
level 5
    
    Reviewed-by: Jeremy Allison <j...@samba.org>

-----------------------------------------------------------------------

Summary of changes:
 auth/ntlmssp/ntlmssp_server.c |    2 +-
 source3/smbd/server_exit.c    |    8 +-------
 2 files changed, 2 insertions(+), 8 deletions(-)


Changeset truncated at 500 lines:

diff --git a/auth/ntlmssp/ntlmssp_server.c b/auth/ntlmssp/ntlmssp_server.c
index d9bea1c..442bd5d 100644
--- a/auth/ntlmssp/ntlmssp_server.c
+++ b/auth/ntlmssp/ntlmssp_server.c
@@ -449,11 +449,11 @@ static NTSTATUS ntlmssp_server_check_password(struct 
gensec_security *gensec_sec
                                                              
&gensec_ntlmssp->server_returned_info,
                                                              user_session_key, 
lm_session_key);
        }
-       talloc_free(user_info);
 
        if (!NT_STATUS_IS_OK(nt_status)) {
                DEBUG(5, (__location__ ": Checking NTLMSSP password for %s\\%s 
failed: %s\n", user_info->client.domain_name, user_info->client.account_name, 
nt_errstr(nt_status)));
        }
+       TALLOC_FREE(user_info);
 
        NT_STATUS_NOT_OK_RETURN(nt_status);
 
diff --git a/source3/smbd/server_exit.c b/source3/smbd/server_exit.c
index fa28374..dfa2b1d 100644
--- a/source3/smbd/server_exit.c
+++ b/source3/smbd/server_exit.c
@@ -202,14 +202,8 @@ static void exit_server_common(enum server_exit_reason how,
        printing_end();
 
        if (how != SERVER_EXIT_NORMAL) {
-               DEBUGSEP(0);
-               DEBUG(0,("Abnormal server exit: %s\n",
-                       reason ? reason : "no explanation provided"));
-               DEBUGSEP(0);
 
-               log_stack_trace();
-
-               dump_core();
+               smb_panic(reason);
 
                /* Notreached. */
                exit(1);


-- 
Samba Shared Repository