The branch, master has been updated via f556e71 Fix bug 9678 - Windows 8 Roaming profiles fail via 148499c security.idl: add new security_secinfo bits from 8f98f5d tevent: change version to 0.9.19
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit f556e71db74e695349c03bf82f68ea6e700eae03 Author: Gregor Beck <gb...@sernet.de> Date: Thu Aug 1 14:16:24 2013 +0200 Fix bug 9678 - Windows 8 Roaming profiles fail Windows 8 tries to set 'ATTRIBUTE_SECURITY_INFORMATION' on some dirs. Ignoring it makes roaming profiles work again. Just like w2k3 gracefully ignore all the other bits. Signed-off-by: Gregor Beck <gb...@sernet.de> Reviewed-by: Stefan Metzmacher <me...@samba.org> Reviewed-by: Jeremy Allison <j...@samba.org> Autobuild-User(master): Jeremy Allison <j...@samba.org> Autobuild-Date(master): Thu Aug 1 20:58:25 CEST 2013 on sn-devel-104 commit 148499cb62acddd07f60102f8c99c38eb6fb5554 Author: Gregor Beck <gb...@sernet.de> Date: Wed Jul 31 15:28:51 2013 +0200 security.idl: add new security_secinfo bits [MS-DTYP].pdf 2.4.7 Signed-off-by: Gregor Beck <gb...@sernet.de> Reviewed-by: Stefan Metzmacher <me...@samba.org> Reviewed-by: Jeremy Allison <j...@samba.org> ----------------------------------------------------------------------- Summary of changes: librpc/idl/security.idl | 3 +++ source3/smbd/nttrans.c | 9 ++------- 2 files changed, 5 insertions(+), 7 deletions(-) Changeset truncated at 500 lines: diff --git a/librpc/idl/security.idl b/librpc/idl/security.idl index 00bb6e6..381d6e5 100644 --- a/librpc/idl/security.idl +++ b/librpc/idl/security.idl @@ -621,6 +621,9 @@ interface security SECINFO_DACL = 0x00000004, SECINFO_SACL = 0x00000008, SECINFO_LABEL = 0x00000010, + SECINFO_ATTRIBUTE = 0x00000020, + SECINFO_SCOPE = 0x00000040, + SECINFO_BACKUP = 0x00010000, SECINFO_UNPROTECTED_SACL = 0x10000000, SECINFO_UNPROTECTED_DACL = 0x20000000, SECINFO_PROTECTED_SACL = 0x40000000, diff --git a/source3/smbd/nttrans.c b/source3/smbd/nttrans.c index c8116b0..800e2fd 100644 --- a/source3/smbd/nttrans.c +++ b/source3/smbd/nttrans.c @@ -891,13 +891,8 @@ NTSTATUS set_sd(files_struct *fsp, struct security_descriptor *psd, /* Ensure we have at least one thing set. */ if ((security_info_sent & (SECINFO_OWNER|SECINFO_GROUP|SECINFO_DACL|SECINFO_SACL)) == 0) { - if (security_info_sent & SECINFO_LABEL) { - /* Only consider SECINFO_LABEL if no other - bits are set. Just like W2K3 we don't - store this. */ - return NT_STATUS_OK; - } - return NT_STATUS_INVALID_PARAMETER; + /* Just like W2K3 */ + return NT_STATUS_OK; } /* Ensure we have the rights to do this. */ -- Samba Shared Repository