The branch, v3-6-test has been updated
       via  87adc21 s3-winbindd: fix fallback to ncacn_np in cm_connect_lsat().
      from  3dd2f64 Fix bug #10097 - MacOSX 10.9 will not follow path-based DFS 
referrals handed out by Samba.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test


- Log -----------------------------------------------------------------
commit 87adc2118677b7cabc3f3b476313b254856f5f9d
Author: Günther Deschner <[email protected]>
Date:   Mon Aug 12 17:23:12 2013 +0200

    s3-winbindd: fix fallback to ncacn_np in cm_connect_lsat().
    
    Fallback to lsa named-pipe connection when tcp connection has failed twice 
(it
    could be a trusted domain connection where we cannot setup a secure 
channel).
    
    Guenther
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=9615
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=9899
    
    Signed-off-by: Günther Deschner <[email protected]>
    Signed-off-by: Andreas Schneider <[email protected]>
    Reviewed-by: Stefan Metzmacher <[email protected]>
    Tested-by: Christof Schmitt <[email protected]>
    
    Autobuild-User(master): Stefan Metzmacher <[email protected]>
    Autobuild-Date(master): Tue Aug 13 20:55:33 CEST 2013 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/winbindd/winbindd_cm.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/winbindd/winbindd_cm.c b/source3/winbindd/winbindd_cm.c
index 9cb3717..c502e83 100644
--- a/source3/winbindd/winbindd_cm.c
+++ b/source3/winbindd/winbindd_cm.c
@@ -2589,11 +2589,16 @@ NTSTATUS cm_connect_lsat(struct winbindd_domain *domain,
                        invalidate_cm_connection(&domain->conn);
                        status = cm_connect_lsa_tcp(domain, mem_ctx, cli);
                }
-               if (!NT_STATUS_IS_OK(status)) {
+               if (NT_STATUS_IS_OK(status)) {
                        return status;
                }
 
-               return NT_STATUS_OK;
+               /*
+                * we tried twice to connect via ncan_ip_tcp and schannel and
+                * failed - maybe it is a trusted domain we can't connect to ?
+                * do not try tcp next time - gd
+                */
+               domain->can_do_ncacn_ip_tcp = false;
        }
 
        status = cm_connect_lsa(domain, mem_ctx, cli, lsa_policy);


-- 
Samba Shared Repository

Reply via email to