[SCM] Samba Shared Repository - branch master updated

[Jeremy Allison]

The branch, master has been updated
       via  740d12d libwbclient: reject unknown named blobs in 
wbcCredentialCache()
       via  6704799 libwbclient: allow only one initial_blob/challenge_blob in 
wbcCredentialCache()
      from  e7c683b s3:vfs:gpfs: remove extra empty lines.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 740d12d1e77d356ff22c3725dce8d5019c86a7a5
Author: Stefan Metzmacher <me...@samba.org>
Date:   Thu Jul 10 05:28:36 2014 +0200

    libwbclient: reject unknown named blobs in wbcCredentialCache()
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=10692
    
    Signed-off-by: Stefan Metzmacher <me...@samba.org>
    Reviewed-by: Jeremy Allison <j...@samba.org>
    
    Autobuild-User(master): Jeremy Allison <j...@samba.org>
    Autobuild-Date(master): Thu Jul 10 22:30:45 CEST 2014 on sn-devel-104

commit 6704799decbbff2ebecf28c771dc77a0b75b8277
Author: Stefan Metzmacher <me...@samba.org>
Date:   Thu Jul 10 05:28:36 2014 +0200

    libwbclient: allow only one initial_blob/challenge_blob in 
wbcCredentialCache()
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=10692
    
    Signed-off-by: Stefan Metzmacher <me...@samba.org>
    Reviewed-by: Jeremy Allison <j...@samba.org>

-----------------------------------------------------------------------

Summary of changes:
 nsswitch/libwbclient/wbc_pam.c |   30 +++++++++++++++++++++---------
 1 files changed, 21 insertions(+), 9 deletions(-)


Changeset truncated at 500 lines:

diff --git a/nsswitch/libwbclient/wbc_pam.c b/nsswitch/libwbclient/wbc_pam.c
index bfd10b7..a16de97 100644
--- a/nsswitch/libwbclient/wbc_pam.c
+++ b/nsswitch/libwbclient/wbc_pam.c
@@ -1207,6 +1207,27 @@ wbcErr wbcCredentialCache(struct 
wbcCredentialCacheParams *params,
                goto fail;
        }
 
+       for (i=0; i<params->num_blobs; i++) {
+               if (strcasecmp(params->blobs[i].name, "initial_blob") == 0) {
+                       if (initial_blob != NULL) {
+                               status = WBC_ERR_INVALID_PARAM;
+                               goto fail;
+                       }
+                       initial_blob = &params->blobs[i];
+                       continue;
+               }
+               if (strcasecmp(params->blobs[i].name, "challenge_blob") == 0) {
+                       if (challenge_blob != NULL) {
+                               status = WBC_ERR_INVALID_PARAM;
+                               goto fail;
+                       }
+                       challenge_blob = &params->blobs[i];
+                       continue;
+               }
+               status = WBC_ERR_INVALID_PARAM;
+               goto fail;
+       }
+
        if (params->domain_name != NULL) {
                status = wbcRequestResponse(WINBINDD_INFO, NULL, &response);
                if (!WBC_ERROR_IS_OK(status)) {
@@ -1224,15 +1245,6 @@ wbcErr wbcCredentialCache(struct 
wbcCredentialCacheParams *params,
        }
        request.data.ccache_ntlm_auth.uid = getuid();
 
-       for (i=0; i<params->num_blobs; i++) {
-               if (strcasecmp(params->blobs[i].name, "initial_blob") == 0) {
-                       initial_blob = &params->blobs[i];
-               }
-               if (strcasecmp(params->blobs[i].name, "challenge_blob") == 0) {
-                       challenge_blob = &params->blobs[i];
-               }
-       }
-
        request.data.ccache_ntlm_auth.initial_blob_len = 0;
        request.data.ccache_ntlm_auth.challenge_blob_len = 0;
        request.extra_len = 0;


-- 
Samba Shared Repository