The branch, master has been updated
via f33224d net: Fix Coverity ID 241039 Unchecked return value
from 431cf20 s3: smbd: open_file: use FSP_POSIX_FLAGS_PATHNAMES
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit f33224dbcfb69d5c503b2037c91efba4d85e56fb
Author: Volker Lendecke <[email protected]>
Date: Wed Dec 23 11:32:04 2015 +0100
net: Fix Coverity ID 241039 Unchecked return value
Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Uri Simchoni <[email protected]>
Autobuild-User(master): Uri Simchoni <[email protected]>
Autobuild-Date(master): Wed Dec 23 17:17:53 CET 2015 on sn-devel-144
-----------------------------------------------------------------------
Summary of changes:
source3/utils/net_ads.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
Changeset truncated at 500 lines:
diff --git a/source3/utils/net_ads.c b/source3/utils/net_ads.c
index 5cc07a0..ace5b27 100644
--- a/source3/utils/net_ads.c
+++ b/source3/utils/net_ads.c
@@ -1910,6 +1910,7 @@ static int net_ads_printer_publish(struct net_context *c,
int argc, const char *
char *prt_dn, *srv_dn, **srv_cn;
char *srv_cn_escaped = NULL, *printername_escaped = NULL;
LDAPMessage *res = NULL;
+ bool ok;
if (argc < 1 || c->display_usage) {
d_printf("%s\n%s",
@@ -1937,7 +1938,14 @@ static int net_ads_printer_publish(struct net_context
*c, int argc, const char *
/* Get printer data from SPOOLSS */
- resolve_name(servername, &server_ss, 0x20, false);
+ ok = resolve_name(servername, &server_ss, 0x20, false);
+ if (!ok) {
+ d_fprintf(stderr, _("Could not find server %s\n"),
+ servername);
+ ads_destroy(&ads);
+ talloc_destroy(mem_ctx);
+ return -1;
+ }
nt_status = cli_full_connection(&cli, lp_netbios_name(), servername,
&server_ss, 0,
--
Samba Shared Repository
