The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree.
The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-02-09-1812/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-02-09-1812/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-144/2016-02-09-1812/samba.stdout The top commit at the time of the failure was: commit b71c2e42308d23f08e1dd38c9a45ee8f25c65404 Author: Amitay Isaacs <[email protected]> Date: Tue Feb 2 15:58:37 2016 +1100 Revert "ctdb-daemon: Check packet generation against database generation" This reverts commit 0ff90f4fac74e61192aff100b168e38ce0adfabb. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11707 The checks against database generation are not required since the global generation is updated as part of updating vnnmap before the actual database recovery. This change was done in 5aab31a39a3589b910a78b96071d6aa5e6547696. Checking only against the database generation is incomplete. It can cause CTDB to abort if the following sequence of events happen. - CTDB gets REQ_DMASTER packet (gen1) This packet processing gets deferred to get a record lock - CTDB goes into recovery, marks RECOVERY_ACTIVE CTDB recovery helper updates vnnmap (gen2) - CTDB processes REQ_DMASTER packet (gen1) The check against database generation (gen1) succeeds. The check for lmaster is now invalid because VNNMAP has changed. This will cause CTDB to abort due to protocol error. Reverting the patch stops processing packets of older generation before they get into call processing. Signed-off-by: Amitay Isaacs <[email protected]> Signed-off-by: Martin Schwenke <[email protected]> Autobuild-User(master): Martin Schwenke <[email protected]> Autobuild-Date(master): Tue Feb 9 12:39:24 CET 2016 on sn-devel-144
