The branch, master has been updated via 32b1f78 LDB: Redudant test on NULL context remove from 3e3e72f s3/rpc_server: mdssvc: suppress compiler warnings from glib headers
https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit 32b1f78b23b0f47d38417f75af1341a0662184f1 Author: Petr Cech <pc...@redhat.com> Date: Mon Mar 21 09:15:17 2016 -0400 LDB: Redudant test on NULL context remove There is redudant test on NULL context in ldb_dn_new_fmt() function. We use this (NULL) context in talloc_vasprintf() function which is able to work with NULL at all. And at the end, we free this newly created (by talloc_vasprintf) context. So it should be safe to remove this check. Signed-off-by: Petr Cech <pc...@redhat.com> Reviewed-by: Simo Sorce <i...@samba.org> Reviewed-by: Jeremy Allison <j...@samba.org> Autobuild-User(master): Jeremy Allison <j...@samba.org> Autobuild-Date(master): Tue Apr 26 08:09:25 CEST 2016 on sn-devel-144 ----------------------------------------------------------------------- Summary of changes: lib/ldb/common/ldb_dn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Changeset truncated at 500 lines: diff --git a/lib/ldb/common/ldb_dn.c b/lib/ldb/common/ldb_dn.c index b7d2de7..ab78776 100644 --- a/lib/ldb/common/ldb_dn.c +++ b/lib/ldb/common/ldb_dn.c @@ -171,7 +171,7 @@ struct ldb_dn *ldb_dn_new_fmt(TALLOC_CTX *mem_ctx, char *strdn; va_list ap; - if ( (! mem_ctx) || (! ldb)) return NULL; + if (! ldb) return NULL; va_start(ap, new_fmt); strdn = talloc_vasprintf(mem_ctx, new_fmt, ap); -- Samba Shared Repository