The branch, master has been updated
via 7a725ee Fix memory leak in share mode locking.
from 1b3b893 s3: auth: Move the declaration of struct dom_sid tmp_sid to
function level scope.
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 7a725eea25f905fc5f611e8f3d7cfe414d5cf913
Author: Hemanth Thummala <[email protected]>
Date: Tue May 24 23:15:04 2016 -0700
Fix memory leak in share mode locking.
Not freeing up(and reparenting to NULL context) ndr buffer
used for TDB updates resulting in huge memory leak when there
in high volume of opens and closes happening on same object.
Free the buffer before reparenting its parent to NULL context.
https://bugzilla.samba.org/show_bug.cgi?id=11934
Signed-off-by: Hemanth Thummala <[email protected]>
Signed-off-by: Saji VR <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>
Reviewed-by: Volker Lendecke <[email protected]>
Autobuild-User(master): Volker Lendecke <[email protected]>
Autobuild-Date(master): Fri May 27 18:43:31 CEST 2016 on sn-devel-144
-----------------------------------------------------------------------
Summary of changes:
source3/locking/share_mode_lock.c | 5 +++++
1 file changed, 5 insertions(+)
Changeset truncated at 500 lines:
diff --git a/source3/locking/share_mode_lock.c
b/source3/locking/share_mode_lock.c
index fe105e3..4e9de03 100644
--- a/source3/locking/share_mode_lock.c
+++ b/source3/locking/share_mode_lock.c
@@ -441,6 +441,11 @@ static int share_mode_data_destructor(struct
share_mode_data *d)
TALLOC_FREE(d->record);
/*
+ * Release the dptr as well before reparenting to NULL
+ * (in-memory cache) context.
+ */
+ TALLOC_FREE(data.dptr);
+ /*
* Reparent d into the in-memory cache so it can be reused if the
* sequence number matches. See parse_share_modes()
* for details.
--
Samba Shared Repository
