The branch, master has been updated
via 910b0ce s4-torture: remove obsolete comment in libsmbclient torture
suite.
from c3aa880 repl_meta_data: Initialise parent_dn to NULL
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 910b0ce2a2e0d671c27a88176ed00e8995669773
Author: Günther Deschner <[email protected]>
Date: Sat Oct 28 11:10:07 2017 +0200
s4-torture: remove obsolete comment in libsmbclient torture suite.
Since smbc_setX calls now handle string allocation using malloc
themselves (since commit 2d41b1ab78639abe4ae030ff482573f464564dd7) we
indeed no longer need to provide malloced strings (the extra malloc
already got removed earlier).
Guenther
Signed-off-by: Günther Deschner <[email protected]>
Reviewed-by: Andreas Schneider <[email protected]>
Autobuild-User(master): Andreas Schneider <[email protected]>
Autobuild-Date(master): Mon Oct 30 21:09:14 CET 2017 on sn-devel-144
-----------------------------------------------------------------------
Summary of changes:
source4/torture/libsmbclient/libsmbclient.c | 2 --
1 file changed, 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/torture/libsmbclient/libsmbclient.c
b/source4/torture/libsmbclient/libsmbclient.c
index 16ad351..a56a5de 100644
--- a/source4/torture/libsmbclient/libsmbclient.c
+++ b/source4/torture/libsmbclient/libsmbclient.c
@@ -36,8 +36,6 @@ bool torture_libsmbclient_init_context(struct torture_context
*tctx,
smbc_setDebug(ctx, DEBUGLEVEL);
smbc_setOptionDebugToStderr(ctx, 1);
- /* yes, libsmbclient API frees the username when freeing the context, so
- * have to pass malloced data here */
smbc_setUser(ctx,
cli_credentials_get_username(popt_get_cmdline_credentials()));
--
Samba Shared Repository