The branch, master has been updated
via 1aabfff libsmb: Remove incorrect fall through comment in
trusts_util.c
via d4ccca2 s3:spoolss: Remove incorrect fall through comment in
srv_spoolss_nt.c
via a31147d s4:lib: Add FALL_THROUGH statements in http.c
via 1563f39 s4:dsdb: Add FALL_THROUGH statements in password_hash.c
via 7619442 s3:winbindd: Add FALL_THROUGH statements in idmap_autorid.c
via 5ba0b72 s3:utils: Add FALL_THROUGH statements in ntlm_auth.c
via 4515312 s3:utils: Add FALL_THROUGH statements in
net_registry_check.c
via 29b5de2 s3:smbd: Add FALL_THROUGH statements in reply.c
via 3e2e409 s3:rpcclient: Add FALL_THROUGH statements in rpcclient.c
via cafe8ac s3:lsa: Add FALL_THROUGH statements in srv_lsa_nt.c
via 824fa2c s3:modules: Add FALL_THROUGH statements in getdate.c
via f5d69d7 s3:libnet: Add FALL_THROUGH statements in libnet_join.c
via 00defe7 nsswitch: Add FALL_THROUGH statements in pam_winbind.c
via 2a646a7 auth:gensec: Add FALL_THROUGH statements in spnego.c
via d123638 auth:credentials: Add FALL_THROUGH statements in
credentials_secrets.c
via 856cda1 s4:torture: Add FALL_THROUGH statements in rpc/spoolss.c
via 50d3a9e s4:torture: Add FALL_THROUGH statements in basic/misc.c
via 1508ff9 s4:rpc_server: Add FALL_THROUGH statements in
dcesrv_srvsvc.c
via e2f1255 s4:auth: Add FALL_THROUGH statements in gensec_krb5.c
via 69fa5ec s4:auth: Add FALL_THROUGH statements in auth_sam.c
via ef3ac40 s4:auth: Add FALL_THROUGH statements in auth_util.c
via 487bd0a s4:samdb: Add FALL_THROUGH statements in linked_attributes.c
via 94d69cd s4:samdb: Add FALL_THROUGH statements in cracknames.c
via d17cb7c s3:rpc_server: Add FALL_THROUGH statements in rpc_server.c
via 7b946e3 s3:utils: Add FALL_THROUGH statements in net_rpc_conf.c
via 3631576 s3:utils: Add FALL_THROUGH statements in net_conf.c
via 273ef59 s3:utils: Add FALL_THROUGH statements in regedit.c
via 964b2d4 s3:smbd: Add FALL_THROUGH statements in trans2.c
via a4623fa s3:smbd: Add FALL_THROUGH statements in nttrans.c
via 4744b77 s3:modules: Add FALL_THROUGH statements in vfs_acl_common.c
via 2cc1306 s3:libsmb: Add FALL_THROUGH statements in dsgetdcname.c
via 3b9aa1c s3:lib: Add FALL_THROUGH statements in util_sd.c
via feeb49f s3:lib: Add FALL_THROUGH statements in sysacls.c
via 3f1a4b7 s3:lib: Add FALL_THROUGH statements in cbuf.c
via 03ed979 s3:auth: Add FALL_THROUGH statements in pampass.c
via 6744e8c s3:auth: Add FALL_THROUGH statements in auth_sam.c
via 64c9ca3 librpc:ndr: Add FALL_THROUGH statements in ndr_cab.c
via 7217219 libgpo: Add FALL_THROUGH statements in gpo_sec.c
via 1741072 lib:tdb: Add FALL_THROUGH statements in common/summary.c
via bdd1de1 lib:tdb: Add FALL_THROUGH statements in tdbtool.c
via 20e3a93 lib:tdb: Add FALL_THROUGH statements in hash.c
via 16d14fa s3:lib: Add FALL_THROUGH statements in util_str.c
via 9fed456 s3:lib: Add FALL_THROUGH statements in util_path.c
via d78d1a7 s3:lib: Add FALL_THROUGH statements in substitute_generic.c
via a3fffd9 lib:util: Add FALL_THROUGH statements in util_file.c
via 8da568e lib:util: Add FALL_THROUGH statements in
charset/charset_macosxfs.c
via 37c6377 lib:util: Add FALL_THROUGH statements in substitute.c
via 2683140 lib:param: Add FALL_THROUGH statements in loadparm.c
via 7adf497 lib:ldb: Add FALL_THROUGH statements in
ldb_map/ldb_map_outbound.c
via 9d2296e lib:ldb: Add FALL_THROUGH statements in ldb_map/ldb_map.c
via 3429e9d lib:ldb: Add FALL_THROUGH statements in
ldb_map/ldb_map_inbound.c
via 2b01bd0 lib:ldb: Add FALL_THROUGH statements in common/ldb_dn.c
via a5104e6 lib:replace: Add FALL_THROUGH statements in strptime.c
via 05dae36 lib:replace: Add FALL_THROUGH support
via 76535df lib:texpect: Avoid some compiler warnings
via d31a8cd s4:lib:com: Fix function declartions
from c21d4bc py3compat: add strings describing bytes/unicode in both
versions
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 1aabfff8a6ecd57ac6475667c2103eb8e3ec6bf3
Author: Andreas Schneider <[email protected]>
Date: Fri Oct 13 11:06:48 2017 +0200
libsmb: Remove incorrect fall through comment in trusts_util.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
Autobuild-User(master): Andrew Bartlett <[email protected]>
Autobuild-Date(master): Thu Mar 1 09:52:37 CET 2018 on sn-devel-144
commit d4ccca2d66536a24afe702dbb969a6ab878d914d
Author: Andreas Schneider <[email protected]>
Date: Fri Oct 13 11:11:24 2017 +0200
s3:spoolss: Remove incorrect fall through comment in srv_spoolss_nt.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit a31147d675c6d557d2b139263134f8617108ba6c
Author: Andreas Schneider <[email protected]>
Date: Fri Oct 13 11:27:38 2017 +0200
s4:lib: Add FALL_THROUGH statements in http.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 1563f392c838798824bec248221a56125350e45c
Author: Andreas Schneider <[email protected]>
Date: Fri Oct 13 11:26:38 2017 +0200
s4:dsdb: Add FALL_THROUGH statements in password_hash.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 7619442a79ca0cff0d2edcab7a9bea36913683bf
Author: Andreas Schneider <[email protected]>
Date: Fri Oct 13 11:25:27 2017 +0200
s3:winbindd: Add FALL_THROUGH statements in idmap_autorid.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 5ba0b72fa3c7d131833e9055a00be2530e73ce75
Author: Andreas Schneider <[email protected]>
Date: Fri Oct 13 11:24:23 2017 +0200
s3:utils: Add FALL_THROUGH statements in ntlm_auth.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 45153120cb03c7e77a7b88f10679ebc7218519c9
Author: Andreas Schneider <[email protected]>
Date: Fri Oct 13 11:18:09 2017 +0200
s3:utils: Add FALL_THROUGH statements in net_registry_check.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 29b5de26df8e562387540ad89b92fc94912ed8a7
Author: Andreas Schneider <[email protected]>
Date: Fri Oct 13 11:15:31 2017 +0200
s3:smbd: Add FALL_THROUGH statements in reply.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 3e2e4096ccb9095847874cbbd89be054299d19ae
Author: Andreas Schneider <[email protected]>
Date: Fri Oct 13 11:13:42 2017 +0200
s3:rpcclient: Add FALL_THROUGH statements in rpcclient.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit cafe8ac9653a8ca9adbbc72e29fd71bf8c13a2d5
Author: Andreas Schneider <[email protected]>
Date: Fri Oct 13 11:12:43 2017 +0200
s3:lsa: Add FALL_THROUGH statements in srv_lsa_nt.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 824fa2c4dbba252cfa778027f0ea7fdfa4fda894
Author: Andreas Schneider <[email protected]>
Date: Fri Oct 13 11:08:36 2017 +0200
s3:modules: Add FALL_THROUGH statements in getdate.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit f5d69d7134ef3a9b73a9d2dcecac42e69319548c
Author: Andreas Schneider <[email protected]>
Date: Thu Jul 27 16:59:40 2017 +0200
s3:libnet: Add FALL_THROUGH statements in libnet_join.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 00defe71009246703a23edd3cf20292821569a86
Author: Andreas Schneider <[email protected]>
Date: Thu Jul 27 16:56:27 2017 +0200
nsswitch: Add FALL_THROUGH statements in pam_winbind.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 2a646a7485eb2e042e7d301b50e418a1aca09b90
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 18:24:26 2017 +0200
auth:gensec: Add FALL_THROUGH statements in spnego.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit d123638a82e14d457572f2d97c0283796b6a1973
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 18:23:31 2017 +0200
auth:credentials: Add FALL_THROUGH statements in credentials_secrets.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 856cda10375e2891d419d5c471df494ddc94976a
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:41:26 2017 +0200
s4:torture: Add FALL_THROUGH statements in rpc/spoolss.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 50d3a9e70d2c5e86d3d26aeb369ebd7a83b60375
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:39:52 2017 +0200
s4:torture: Add FALL_THROUGH statements in basic/misc.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 1508ff9cc45ea7e848e3373f66c83006a5a47d37
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:39:04 2017 +0200
s4:rpc_server: Add FALL_THROUGH statements in dcesrv_srvsvc.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit e2f1255840b0066c223f1f9caf7a3865fa4021a3
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:33:12 2017 +0200
s4:auth: Add FALL_THROUGH statements in gensec_krb5.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 69fa5ecb6acaacdc0fbd8942baa3bbba1dabb75a
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:30:53 2017 +0200
s4:auth: Add FALL_THROUGH statements in auth_sam.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit ef3ac405bf436fa6fd7daf20e0c90856dae8237f
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:29:55 2017 +0200
s4:auth: Add FALL_THROUGH statements in auth_util.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 487bd0a1e94c121daaf98acbb575612db297a520
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:28:11 2017 +0200
s4:samdb: Add FALL_THROUGH statements in linked_attributes.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 94d69cd4b8d9c50908615e152766af3c93011e4a
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:21:02 2017 +0200
s4:samdb: Add FALL_THROUGH statements in cracknames.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit d17cb7cebfa7d4525dca24668a35bd1d26034c42
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:42:46 2017 +0200
s3:rpc_server: Add FALL_THROUGH statements in rpc_server.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 7b946e3480fc964895e1ef9bac340361aa209aa1
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:58:40 2017 +0200
s3:utils: Add FALL_THROUGH statements in net_rpc_conf.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 36315769b87d8de0482cb5090a9ddcda975f3c45
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:57:10 2017 +0200
s3:utils: Add FALL_THROUGH statements in net_conf.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 273ef597616dc41620860781fe0e19cc747fe931
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:55:35 2017 +0200
s3:utils: Add FALL_THROUGH statements in regedit.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 964b2d4aae5a4700a0e74725e6246f856df248b7
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:52:06 2017 +0200
s3:smbd: Add FALL_THROUGH statements in trans2.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit a4623fac64b7471e3dbde5cfca8f9dfa0ec28761
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:50:18 2017 +0200
s3:smbd: Add FALL_THROUGH statements in nttrans.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 4744b777f5143b8956afb29ea2b35a8248c7daf9
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:53:45 2017 +0200
s3:modules: Add FALL_THROUGH statements in vfs_acl_common.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 2cc130683e9b885739b4ae7952f1618277100bc2
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:36:50 2017 +0200
s3:libsmb: Add FALL_THROUGH statements in dsgetdcname.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 3b9aa1c625b0cc5ef55cc74602b6160443691e46
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:54:48 2017 +0200
s3:lib: Add FALL_THROUGH statements in util_sd.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit feeb49f4cfe6260daba1c873d27cd848f063e8bd
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:51:08 2017 +0200
s3:lib: Add FALL_THROUGH statements in sysacls.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 3f1a4b749d4157d075cd9146ab5d10d5d0e6ceec
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:25:30 2017 +0200
s3:lib: Add FALL_THROUGH statements in cbuf.c
commit 03ed979eb0cfa37fb25cbaacc9e7a6fd871a8ec9
Author: Andreas Schneider <[email protected]>
Date: Thu Jul 27 16:55:23 2017 +0200
s3:auth: Add FALL_THROUGH statements in pampass.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 6744e8c7d4fb9fcb27cf940608118bd28ea2af2e
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:35:28 2017 +0200
s3:auth: Add FALL_THROUGH statements in auth_sam.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 64c9ca3a3df42dd19e0ed2981d2e1b3cb0990ca4
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:03:09 2017 +0200
librpc:ndr: Add FALL_THROUGH statements in ndr_cab.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 721721911595c649b5cb549f19873eb8f07d2590
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:43:53 2017 +0200
libgpo: Add FALL_THROUGH statements in gpo_sec.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 17410725065da5040f9c6eae2383a960b7712156
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 18:28:12 2017 +0200
lib:tdb: Add FALL_THROUGH statements in common/summary.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit bdd1de17109f9f4ed6435851d74b97d19ffe6da1
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 16:58:00 2017 +0200
lib:tdb: Add FALL_THROUGH statements in tdbtool.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 20e3a93c3b5b580abef4b2ab7eccc5f1be5d4b77
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 16:55:10 2017 +0200
lib:tdb: Add FALL_THROUGH statements in hash.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 16d14fa86321f30ce2798aa5e4b9be493c267807
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:25:20 2017 +0200
s3:lib: Add FALL_THROUGH statements in util_str.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 9fed4562cae3e7e2b528b94176b6063522f332eb
Author: Andreas Schneider <[email protected]>
Date: Thu Jul 27 16:57:38 2017 +0200
s3:lib: Add FALL_THROUGH statements in util_path.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit d78d1a71ffa166a95729e273a68e012f2965120e
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 17:22:44 2017 +0200
s3:lib: Add FALL_THROUGH statements in substitute_generic.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit a3fffd970c38e288476643fbea6cfa1943213b8d
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 18:41:25 2017 +0200
lib:util: Add FALL_THROUGH statements in util_file.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 8da568efea444af26c7f63ba73de65c4a9f24e7d
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 18:40:14 2017 +0200
lib:util: Add FALL_THROUGH statements in charset/charset_macosxfs.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 37c637766eabd1123b259acbb3ae4eeb6b10de4a
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 16:49:50 2017 +0200
lib:util: Add FALL_THROUGH statements in substitute.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 2683140674fe37f449029870f0a2b6588b10a2b0
Author: Andreas Schneider <[email protected]>
Date: Thu Jul 27 15:20:57 2017 +0200
lib:param: Add FALL_THROUGH statements in loadparm.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 7adf497443f40aa381c242e5d72970369b021958
Author: Andreas Schneider <[email protected]>
Date: Thu Jul 27 15:20:04 2017 +0200
lib:ldb: Add FALL_THROUGH statements in ldb_map/ldb_map_outbound.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 9d2296e070157ba9d4d4f80714ba8b1ad6691117
Author: Andreas Schneider <[email protected]>
Date: Thu Jul 27 15:19:23 2017 +0200
lib:ldb: Add FALL_THROUGH statements in ldb_map/ldb_map.c
commit 3429e9d9e59706ff2d17989530b67c74f80b879e
Author: Andreas Schneider <[email protected]>
Date: Thu Jul 27 15:18:28 2017 +0200
lib:ldb: Add FALL_THROUGH statements in ldb_map/ldb_map_inbound.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 2b01bd0475d6cb654f1ffbbc56152bf04d1a793d
Author: Andreas Schneider <[email protected]>
Date: Thu Jul 27 15:17:21 2017 +0200
lib:ldb: Add FALL_THROUGH statements in common/ldb_dn.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit a5104e6a396ded1c2f603eff5bf8fc89bfe3bb61
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 18:25:46 2017 +0200
lib:replace: Add FALL_THROUGH statements in strptime.c
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 05dae361b388e71701a7c646f2787315e9bd5dfb
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 16:33:10 2017 +0200
lib:replace: Add FALL_THROUGH support
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit 76535df3248b7f4e489d1555f27cedd151cd1a50
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 16:51:39 2017 +0200
lib:texpect: Avoid some compiler warnings
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
commit d31a8cd800db3862cf7e6935f135705af647b1d0
Author: Andreas Schneider <[email protected]>
Date: Wed Jul 26 18:16:43 2017 +0200
s4:lib:com: Fix function declartions
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
.ycm_extra_conf.py | 1 +
auth/credentials/credentials_secrets.c | 3 +-
auth/gensec/spnego.c | 2 +-
lib/ldb/common/ldb_dn.c | 3 +-
lib/ldb/ldb_map/ldb_map.c | 6 ++-
lib/ldb/ldb_map/ldb_map_inbound.c | 6 ++-
lib/ldb/ldb_map/ldb_map_outbound.c | 3 +-
lib/param/loadparm.c | 3 +-
lib/replace/replace.h | 9 ++++
lib/replace/strptime.c | 6 ++-
lib/replace/wscript | 36 ++++++++++++++++
lib/tdb/common/hash.c | 50 +++++++++++-----------
lib/tdb/common/summary.c | 3 +-
lib/tdb/tools/tdbtool.c | 3 ++
lib/texpect/texpect.c | 9 ++++
lib/util/charset/charset_macosxfs.c | 14 +++---
lib/util/substitute.c | 2 +
lib/util/util_file.c | 3 +-
libgpo/gpo_sec.c | 6 ++-
librpc/idl/dcom.idl | 2 +-
librpc/ndr/ndr_cab.c | 3 ++
nsswitch/pam_winbind.c | 3 +-
source3/auth/auth_sam.c | 4 ++
source3/auth/pampass.c | 4 +-
source3/lib/cbuf.c | 3 +-
source3/lib/substitute_generic.c | 2 +
source3/lib/sysacls.c | 6 ++-
source3/lib/util_path.c | 12 ++++--
source3/lib/util_sd.c | 2 +
source3/lib/util_str.c | 4 ++
source3/libnet/libnet_join.c | 3 +-
source3/libsmb/dsgetdcname.c | 2 +
source3/libsmb/trusts_util.c | 1 -
source3/modules/getdate.c | 5 ++-
source3/modules/vfs_acl_common.c | 1 +
source3/rpc_server/lsa/srv_lsa_nt.c | 6 ++-
source3/rpc_server/rpc_server.c | 3 +-
source3/rpc_server/spoolss/srv_spoolss_nt.c | 1 -
source3/rpcclient/rpcclient.c | 2 +-
source3/smbd/nttrans.c | 1 +
source3/smbd/reply.c | 8 ++--
source3/smbd/trans2.c | 3 +-
source3/utils/net_conf.c | 8 ++++
source3/utils/net_registry_check.c | 3 +-
source3/utils/net_rpc_conf.c | 8 ++++
source3/utils/ntlm_auth.c | 4 +-
source3/utils/regedit.c | 3 +-
source3/winbindd/idmap_autorid.c | 2 +-
source4/auth/gensec/gensec_krb5.c | 5 +--
source4/auth/ntlm/auth_sam.c | 2 +-
source4/auth/ntlm/auth_util.c | 9 ++--
source4/dsdb/samdb/cracknames.c | 2 +-
source4/dsdb/samdb/ldb_modules/linked_attributes.c | 3 +-
source4/dsdb/samdb/ldb_modules/password_hash.c | 2 +-
source4/lib/com/classes/simple.c | 4 +-
source4/lib/com/main.c | 4 +-
source4/lib/http/http.c | 2 +-
source4/rpc_server/srvsvc/dcesrv_srvsvc.c | 4 ++
source4/torture/basic/misc.c | 2 +
source4/torture/rpc/spoolss.c | 2 +
60 files changed, 225 insertions(+), 93 deletions(-)
Changeset truncated at 500 lines:
diff --git a/.ycm_extra_conf.py b/.ycm_extra_conf.py
index c96b59e..97122a9 100644
--- a/.ycm_extra_conf.py
+++ b/.ycm_extra_conf.py
@@ -47,6 +47,7 @@ flags = [
'-D_XOPEN_SOURCE_EXTENDED=1',
'-DAD_DC_BUILD_IS_ENABLED=1',
'-DHAVE_IPV6=1',
+ '-DFALL_THROUGH',
'-I/usr/local/include',
'-I.',
'-Iauth',
diff --git a/auth/credentials/credentials_secrets.c
b/auth/credentials/credentials_secrets.c
index beb2928..ae1d23b 100644
--- a/auth/credentials/credentials_secrets.c
+++ b/auth/credentials/credentials_secrets.c
@@ -372,7 +372,8 @@ _PUBLIC_ NTSTATUS
cli_credentials_set_machine_account_db_ctx(struct cli_credenti
if (security != SEC_ADS) {
break;
}
- /* fall through */
+
+ FALL_THROUGH;
case ROLE_ACTIVE_DIRECTORY_DC:
use_kerberos = CRED_AUTO_USE_KERBEROS;
break;
diff --git a/auth/gensec/spnego.c b/auth/gensec/spnego.c
index 56f9be4..0b3fbdc 100644
--- a/auth/gensec/spnego.c
+++ b/auth/gensec/spnego.c
@@ -1649,7 +1649,7 @@ static struct tevent_req
*gensec_spnego_update_send(TALLOC_CTX *mem_ctx,
return tevent_req_post(req, ev);
}
- /* fall through */
+ FALL_THROUGH;
case SPNEGO_CLIENT_START:
case SPNEGO_SERVER_START:
diff --git a/lib/ldb/common/ldb_dn.c b/lib/ldb/common/ldb_dn.c
index b23ee17..dfeb600 100644
--- a/lib/ldb/common/ldb_dn.c
+++ b/lib/ldb/common/ldb_dn.c
@@ -629,7 +629,8 @@ static bool ldb_dn_explode(struct ldb_dn *dn)
l++;
break;
}
- /* fall through */
+
+ FALL_THROUGH;
case '\"':
case '<':
case '>':
diff --git a/lib/ldb/ldb_map/ldb_map.c b/lib/ldb/ldb_map/ldb_map.c
index f2a86fe..b453dff 100644
--- a/lib/ldb/ldb_map/ldb_map.c
+++ b/lib/ldb/ldb_map/ldb_map.c
@@ -523,7 +523,8 @@ struct ldb_dn *ldb_dn_map_local(struct ldb_module *module,
void *mem_ctx, struct
"used in DN!",
ldb_dn_get_component_name(dn, i));
goto failed;
}
- /* fall through */
+
+ FALL_THROUGH;
case LDB_MAP_KEEP:
case LDB_MAP_RENAME:
case LDB_MAP_RENDROP:
@@ -599,7 +600,8 @@ struct ldb_dn *ldb_dn_map_remote(struct ldb_module *module,
void *mem_ctx, struc
"used in DN!",
ldb_dn_get_component_name(dn, i));
goto failed;
}
- /* fall through */
+
+ FALL_THROUGH;
case LDB_MAP_KEEP:
case LDB_MAP_RENAME:
case LDB_MAP_RENDROP:
diff --git a/lib/ldb/ldb_map/ldb_map_inbound.c
b/lib/ldb/ldb_map/ldb_map_inbound.c
index 461e681..861c4c1 100644
--- a/lib/ldb/ldb_map/ldb_map_inbound.c
+++ b/lib/ldb/ldb_map/ldb_map_inbound.c
@@ -87,7 +87,8 @@ static int ldb_msg_el_partition(struct ldb_module *module,
enum ldb_request_type
el = ldb_msg_el_map_local(module, remote, map, old);
break;
}
- /* fall through */
+
+ FALL_THROUGH;
case LDB_MAP_IGNORE:
goto local;
@@ -99,7 +100,8 @@ static int ldb_msg_el_partition(struct ldb_module *module,
enum ldb_request_type
map->local_name);
goto local;
}
- /* fall through */
+
+ FALL_THROUGH;
case LDB_MAP_KEEP:
case LDB_MAP_RENAME:
el = ldb_msg_el_map_local(module, remote, map, old);
diff --git a/lib/ldb/ldb_map/ldb_map_outbound.c
b/lib/ldb/ldb_map/ldb_map_outbound.c
index fd25c36..1f1a7e8 100644
--- a/lib/ldb/ldb_map/ldb_map_outbound.c
+++ b/lib/ldb/ldb_map/ldb_map_outbound.c
@@ -330,7 +330,8 @@ static int ldb_msg_el_merge(struct ldb_module *module,
struct ldb_message *local
attr_name);
return LDB_SUCCESS;
}
- /* fall through */
+
+ FALL_THROUGH;
case LDB_MAP_KEEP:
case LDB_MAP_RENAME:
case LDB_MAP_RENDROP:
diff --git a/lib/param/loadparm.c b/lib/param/loadparm.c
index efad4a1..b46700d 100644
--- a/lib/param/loadparm.c
+++ b/lib/param/loadparm.c
@@ -2058,7 +2058,8 @@ void lpcfg_print_parameter(struct parm_struct *p, void
*ptr, FILE * f)
case P_CMDLIST:
list_sep = " ";
- /* fall through */
+
+ FALL_THROUGH;
case P_LIST:
if ((char ***)ptr && *(char ***)ptr) {
char **list = *(char ***)ptr;
diff --git a/lib/replace/replace.h b/lib/replace/replace.h
index 128978c..e2a5541 100644
--- a/lib/replace/replace.h
+++ b/lib/replace/replace.h
@@ -922,6 +922,15 @@ void rep_setproctitle(const char *fmt, ...)
PRINTF_ATTRIBUTE(1, 2);
#define setproctitle_init rep_setproctitle_init
void rep_setproctitle_init(int argc, char *argv[], char *envp[]);
#endif
+
+#ifndef FALL_THROUGH
+# ifdef HAVE_FALLTHROUGH_ATTRIBUTE
+# define FALL_THROUGH __attribute__ ((fallthrough))
+# else /* HAVE_FALLTHROUGH_ATTRIBUTE */
+# define FALL_THROUGH ((void)0)
+# endif /* HAVE_FALLTHROUGH_ATTRIBUTE */
+#endif /* FALL_THROUGH */
+
bool nss_wrapper_enabled(void);
bool nss_wrapper_hosts_enabled(void);
bool socket_wrapper_enabled(void);
diff --git a/lib/replace/strptime.c b/lib/replace/strptime.c
index 20e5d8c..bbc7422 100644
--- a/lib/replace/strptime.c
+++ b/lib/replace/strptime.c
@@ -462,7 +462,8 @@ strptime_internal (rp, fmt, tm, decided, era_cnt)
*decided = raw;
}
#endif
- /* Fall through. */
+
+ FALL_THROUGH;
case 'D':
/* Match standard day format. */
if (!recursive (HERE_D_FMT))
@@ -611,7 +612,8 @@ strptime_internal (rp, fmt, tm, decided, era_cnt)
*decided = raw;
}
#endif
- /* Fall through. */
+
+ FALL_THROUGH;
case 'T':
if (!recursive (HERE_T_FMT))
return NULL;
diff --git a/lib/replace/wscript b/lib/replace/wscript
index a2e2d11..534062e 100644
--- a/lib/replace/wscript
+++ b/lib/replace/wscript
@@ -249,6 +249,42 @@ def configure(conf):
headers='stdint.h sys/atomic.h',
msg='Checking for atomic_add_32 compiler builtin')
+ conf.CHECK_CODE('''
+ #define FALL_THROUGH __attribute__((fallthrough))
+
+ enum direction_e {
+ UP = 0,
+ DOWN,
+ };
+
+ int main(void) {
+ enum direction_e key = UP;
+ int i = 10;
+ int j = 0;
+
+ switch (key) {
+ case UP:
+ i = 5;
+ FALL_THROUGH;
+ case DOWN:
+ j = i * 2;
+ break;
+ default:
+ break;
+ }
+
+ if (j < i) {
+ return 1;
+ }
+
+ return 0;
+ }
+ ''',
+ 'HAVE_FALLTHROUGH_ATTRIBUTE',
+ addmain=False,
+ cflags='-Werror',
+ msg='Checking for fallthrough attribute')
+
# these may be builtins, so we need the link=False strategy
conf.CHECK_FUNCS('strdup memmem printf memset memcpy memmove strcpy
strncpy bzero', link=False)
diff --git a/lib/tdb/common/hash.c b/lib/tdb/common/hash.c
index 1eed722..4de7ba9 100644
--- a/lib/tdb/common/hash.c
+++ b/lib/tdb/common/hash.c
@@ -232,16 +232,16 @@ static uint32_t hashlittle( const void *key, size_t
length )
switch(length)
{
case 12: c+=k[2]; b+=k[1]; a+=k[0]; break;
- case 11: c+=((uint32_t)k8[10])<<16; /* fall through */
- case 10: c+=((uint32_t)k8[9])<<8; /* fall through */
- case 9 : c+=k8[8]; /* fall through */
+ case 11: c+=((uint32_t)k8[10])<<16; FALL_THROUGH;
+ case 10: c+=((uint32_t)k8[9])<<8; FALL_THROUGH;
+ case 9 : c+=k8[8]; FALL_THROUGH;
case 8 : b+=k[1]; a+=k[0]; break;
- case 7 : b+=((uint32_t)k8[6])<<16; /* fall through */
- case 6 : b+=((uint32_t)k8[5])<<8; /* fall through */
- case 5 : b+=k8[4]; /* fall through */
+ case 7 : b+=((uint32_t)k8[6])<<16; FALL_THROUGH;
+ case 6 : b+=((uint32_t)k8[5])<<8; FALL_THROUGH;
+ case 5 : b+=k8[4]; FALL_THROUGH;
case 4 : a+=k[0]; break;
- case 3 : a+=((uint32_t)k8[2])<<16; /* fall through */
- case 2 : a+=((uint32_t)k8[1])<<8; /* fall through */
+ case 3 : a+=((uint32_t)k8[2])<<16; FALL_THROUGH;
+ case 2 : a+=((uint32_t)k8[1])<<8; FALL_THROUGH;
case 1 : a+=k8[0]; break;
case 0 : return c;
}
@@ -268,23 +268,23 @@ static uint32_t hashlittle( const void *key, size_t
length )
b+=k[2]+(((uint32_t)k[3])<<16);
a+=k[0]+(((uint32_t)k[1])<<16);
break;
- case 11: c+=((uint32_t)k8[10])<<16; /* fall through */
+ case 11: c+=((uint32_t)k8[10])<<16; FALL_THROUGH;
case 10: c+=k[4];
b+=k[2]+(((uint32_t)k[3])<<16);
a+=k[0]+(((uint32_t)k[1])<<16);
break;
- case 9 : c+=k8[8]; /* fall through */
+ case 9 : c+=k8[8]; FALL_THROUGH;
case 8 : b+=k[2]+(((uint32_t)k[3])<<16);
a+=k[0]+(((uint32_t)k[1])<<16);
break;
- case 7 : b+=((uint32_t)k8[6])<<16; /* fall through */
+ case 7 : b+=((uint32_t)k8[6])<<16; FALL_THROUGH;
case 6 : b+=k[2];
a+=k[0]+(((uint32_t)k[1])<<16);
break;
- case 5 : b+=k8[4]; /* fall through */
+ case 5 : b+=k8[4]; FALL_THROUGH;
case 4 : a+=k[0]+(((uint32_t)k[1])<<16);
break;
- case 3 : a+=((uint32_t)k8[2])<<16; /* fall through */
+ case 3 : a+=((uint32_t)k8[2])<<16; FALL_THROUGH;
case 2 : a+=k[0];
break;
case 1 : a+=k8[0];
@@ -316,19 +316,19 @@ static uint32_t hashlittle( const void *key, size_t
length )
}
/*-------------------------------- last block: affect all 32 bits of (c) */
- switch(length) /* all the case statements fall through */
+ switch(length)
{
- case 12: c+=((uint32_t)k[11])<<24;
- case 11: c+=((uint32_t)k[10])<<16;
- case 10: c+=((uint32_t)k[9])<<8;
- case 9 : c+=k[8];
- case 8 : b+=((uint32_t)k[7])<<24;
- case 7 : b+=((uint32_t)k[6])<<16;
- case 6 : b+=((uint32_t)k[5])<<8;
- case 5 : b+=k[4];
- case 4 : a+=((uint32_t)k[3])<<24;
- case 3 : a+=((uint32_t)k[2])<<16;
- case 2 : a+=((uint32_t)k[1])<<8;
+ case 12: c+=((uint32_t)k[11])<<24; FALL_THROUGH;
+ case 11: c+=((uint32_t)k[10])<<16; FALL_THROUGH;
+ case 10: c+=((uint32_t)k[9])<<8; FALL_THROUGH;
+ case 9 : c+=k[8]; FALL_THROUGH;
+ case 8 : b+=((uint32_t)k[7])<<24; FALL_THROUGH;
+ case 7 : b+=((uint32_t)k[6])<<16; FALL_THROUGH;
+ case 6 : b+=((uint32_t)k[5])<<8; FALL_THROUGH;
+ case 5 : b+=k[4]; FALL_THROUGH;
+ case 4 : a+=((uint32_t)k[3])<<24; FALL_THROUGH;
+ case 3 : a+=((uint32_t)k[2])<<16; FALL_THROUGH;
+ case 2 : a+=((uint32_t)k[1])<<8; FALL_THROUGH;
case 1 : a+=k[0];
break;
case 0 : return c;
diff --git a/lib/tdb/common/summary.c b/lib/tdb/common/summary.c
index d786132..c9b5bc4 100644
--- a/lib/tdb/common/summary.c
+++ b/lib/tdb/common/summary.c
@@ -151,7 +151,8 @@ _PUBLIC_ char *tdb_summary(struct tdb_context *tdb)
rec.rec_len = tdb_dead_space(tdb, off)
- sizeof(rec);
}
- /* Fall through */
+
+ FALL_THROUGH;
case TDB_DEAD_MAGIC:
tally_add(&dead, rec.rec_len);
break;
diff --git a/lib/tdb/tools/tdbtool.c b/lib/tdb/tools/tdbtool.c
index e3535b9..d8bacdb 100644
--- a/lib/tdb/tools/tdbtool.c
+++ b/lib/tdb/tools/tdbtool.c
@@ -930,10 +930,13 @@ int main(int argc, char *argv[])
break;
case 5:
arg2 = tdb_convert_string(argv[4],&arg2len);
+ FALL_THROUGH;
case 4:
arg1 = tdb_convert_string(argv[3],&arg1len);
+ FALL_THROUGH;
case 3:
cmdname = argv[2];
+ FALL_THROUGH;
default:
do_command();
break;
diff --git a/lib/texpect/texpect.c b/lib/texpect/texpect.c
index b553de8..dd78670 100644
--- a/lib/texpect/texpect.c
+++ b/lib/texpect/texpect.c
@@ -434,6 +434,9 @@ int main(int argc, const char **argv)
switch (pid) {
case -1:
err(1, "Failed to fork");
+
+ /* Never reached */
+ return 1;
case 0:
if(setsid()<0)
@@ -448,6 +451,9 @@ int main(int argc, const char **argv)
/* texpect <expect_instructions> <progname> [<args>] */
execvp(program, program_args);
err(1, "Failed to exec: %s", program);
+
+ /* Never reached */
+ return 1;
default:
close(slave);
{
@@ -462,4 +468,7 @@ int main(int argc, const char **argv)
return eval_parent(pid);
}
+
+ /* Never reached */
+ return 1;
}
diff --git a/lib/util/charset/charset_macosxfs.c
b/lib/util/charset/charset_macosxfs.c
index 895277d..24e21fd 100644
--- a/lib/util/charset/charset_macosxfs.c
+++ b/lib/util/charset/charset_macosxfs.c
@@ -457,10 +457,11 @@ static size_t macosxfs_encoding_pull(
switch(result) {
case kCFStringEncodingConversionSuccess:
- if (*inbytesleft == srcCharsUsed)
+ if (*inbytesleft == srcCharsUsed) {
break;
- else
- ; /*fall through*/
+ }
+
+ FALL_THROUGH;
case kCFStringEncodingInsufficientOutputBufferLength:
debug_out("String conversion: "
"Output buffer too small\n");
@@ -546,10 +547,11 @@ static size_t macosxfs_encoding_push(
switch(result) {
case kCFStringEncodingConversionSuccess:
- if (*inbytesleft/2 == srcCharsUsed)
+ if (*inbytesleft/2 == srcCharsUsed) {
break;
- else
- ; /*fall through*/
+ }
+
+ FALL_THROUGH;
case kCFStringEncodingInsufficientOutputBufferLength:
debug_out("String conversion: "
"Output buffer too small\n");
diff --git a/lib/util/substitute.c b/lib/util/substitute.c
index 49adeaf..2c18257 100644
--- a/lib/util/substitute.c
+++ b/lib/util/substitute.c
@@ -84,6 +84,7 @@ static void string_sub2(char *s,const char *pattern, const
char *insert, size_t
p[i] = insert[i];
break;
}
+ FALL_THROUGH;
case '`':
case '"':
case '\'':
@@ -98,6 +99,7 @@ static void string_sub2(char *s,const char *pattern, const
char *insert, size_t
* not replacing unsafe chars */
break;
}
+ FALL_THROUGH;
default:
p[i] = insert[i];
}
diff --git a/lib/util/util_file.c b/lib/util/util_file.c
index ac82060..499e8c4 100644
--- a/lib/util/util_file.c
+++ b/lib/util/util_file.c
@@ -130,7 +130,8 @@ char *fgets_slash(TALLOC_CTX *mem_ctx, char *s2, int
maxlen, FILE *f)
if (start_of_line) {
break;
}
- /* fall through */
+
+ FALL_THROUGH;
default:
start_of_line = false;
s[len++] = c;
diff --git a/libgpo/gpo_sec.c b/libgpo/gpo_sec.c
index af73697..98ee8eb 100644
--- a/libgpo/gpo_sec.c
+++ b/libgpo/gpo_sec.c
@@ -47,13 +47,15 @@ static bool gpo_sd_check_agp_object_guid(const struct
security_ace_object *objec
&ext_right_apg_guid)) {
return true;
}
- /* FALL TROUGH */
+
+ FALL_THROUGH;
case SEC_ACE_INHERITED_OBJECT_TYPE_PRESENT:
if (GUID_equal(&object->inherited_type.inherited_type,
&ext_right_apg_guid)) {
return true;
}
- /* FALL TROUGH */
+
+ FALL_THROUGH;
default:
break;
}
diff --git a/librpc/idl/dcom.idl b/librpc/idl/dcom.idl
index e53d7b8..5559811 100644
--- a/librpc/idl/dcom.idl
+++ b/librpc/idl/dcom.idl
@@ -52,7 +52,7 @@ interface IUnknown
[local] WERROR CreateInstance(
[in,unique] MInterfacePointer *pUnknown,
[in,unique] GUID *iid,
- [out, iid_is(riid),unique] MInterfacePointer *ppv
+ [out, iid_is(riid),unique] MInterfacePointer **ppv
);
[call_as(CreateInstance)] WERROR RemoteCreateInstance();
diff --git a/librpc/ndr/ndr_cab.c b/librpc/ndr/ndr_cab.c
index 837ed25..c415bfa 100644
--- a/librpc/ndr/ndr_cab.c
+++ b/librpc/ndr/ndr_cab.c
@@ -95,10 +95,13 @@ static uint32_t ndr_cab_compute_checksum(uint8_t *data,
uint32_t length, uint32_
switch (length % 4) {
case 3:
ul |= (((uint32_t)(*pb++)) << 16);
+ FALL_THROUGH;
case 2:
ul |= (((uint32_t)(*pb++)) << 8);
+ FALL_THROUGH;
case 1:
ul |= (uint32_t)(*pb++);
+ FALL_THROUGH;
default:
break;
}
diff --git a/nsswitch/pam_winbind.c b/nsswitch/pam_winbind.c
index e14fcfe..63fede8 100644
--- a/nsswitch/pam_winbind.c
+++ b/nsswitch/pam_winbind.c
@@ -2886,7 +2886,8 @@ int pam_sm_acct_mgmt(pam_handle_t *pamh, int flags,
--
Samba Shared Repository
