The branch, master has been updated
via 924f3f0 wafsamba: Add '-Werror=strict-overflow -Wstrict-overflow=2'
to the developer build
via 9bf489d s3: nmbd: Fix strict overflow checking compiler warning.
from 7a1e69e eventlog: Fix CID 1363194 Resource leak
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 924f3f000e627f0c12f1b2381608b3182c2d53c5
Author: Andreas Schneider <[email protected]>
Date: Thu Apr 5 13:33:56 2018 -0700
wafsamba: Add '-Werror=strict-overflow -Wstrict-overflow=2' to the
developer build
We could move it to 3, but shouldn't go higher. If you set it to 4 and 5
you will probably also get a lot of false positives.
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>
Autobuild-User(master): Jeremy Allison <[email protected]>
Autobuild-Date(master): Fri Apr 6 02:07:16 CEST 2018 on sn-devel-144
commit 9bf489d8d5838e73afaaca263485a332b14b174e
Author: Stefan Metzmacher <[email protected]>
Date: Thu Apr 5 13:28:12 2018 -0700
s3: nmbd: Fix strict overflow checking compiler warning.
Signed-off-by: Stefan Metzmacher <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
buildtools/wafsamba/samba_autoconf.py | 2 ++
source3/nmbd/nmbd_incomingrequests.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
Changeset truncated at 500 lines:
diff --git a/buildtools/wafsamba/samba_autoconf.py
b/buildtools/wafsamba/samba_autoconf.py
index 35f4f36..bdd7c8b 100644
--- a/buildtools/wafsamba/samba_autoconf.py
+++ b/buildtools/wafsamba/samba_autoconf.py
@@ -713,6 +713,8 @@ def SAMBA_CONFIG_H(conf, path=None):
testflags=True)
conf.ADD_CFLAGS('-Wimplicit-fallthrough',
testflags=True)
+ conf.ADD_CFLAGS('-Werror=strict-overflow -Wstrict-overflow=2',
+ testflags=True)
conf.ADD_CFLAGS('-Wformat=2 -Wno-format-y2k', testflags=True)
conf.ADD_CFLAGS('-Wno-format-zero-length', testflags=True)
diff --git a/source3/nmbd/nmbd_incomingrequests.c
b/source3/nmbd/nmbd_incomingrequests.c
index 6f3eee3..96cb124 100644
--- a/source3/nmbd/nmbd_incomingrequests.c
+++ b/source3/nmbd/nmbd_incomingrequests.c
@@ -341,7 +341,7 @@ subnet %s - name not found.\n",
nmb_namestr(&nmb->question.question_name),
namerec = subrec->namelist;
- while (buf < bufend) {
+ while (PTR_DIFF(bufend, buf) > 0) {
if( (namerec->data.source == SELF_NAME) ||
(namerec->data.source == PERMANENT_NAME) ) {
int name_type = namerec->name.name_type;
unstring name;
--
Samba Shared Repository
